From: Jens Axboe <jens.axboe@oracle.com>
To: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 5/8] cciss: disable DMA prefetch for P600
Date: Thu, 2 Nov 2006 15:12:13 +0100 [thread overview]
Message-ID: <20061102141213.GJ13555@kernel.dk> (raw)
In-Reply-To: <20061101220633.GE29928@beardog.cca.cpqcorp.net>
On Wed, Nov 01 2006, Mike Miller (OS Dev) wrote:
>
> PATCH 5/8
>
> This disables DMA prefetch for the P600 on IPF. A chip bug may result in
> a DMA prefetch going falling off into holes in memory. On Proliant x86[_64]
> systems the top page of memory is mapped out and the io hole below 4GB is
> similiarly protected because the memory at the lower boundary of the hole
> is used by ACPI and other things.
> Please consider this for inclusion.
>
> Thanks,
> mikem
>
> Signed-off-by: Mike Miller <mike.miller@hp.com>
>
> cciss.c | 14 ++++++++++++++
> cciss_cmd.h | 1 +
> 2 files changed, 15 insertions(+)
> --------------------------------------------------------------------------------
> diff -urNp linux-2.6-p00004/drivers/block/cciss.c linux-2.6/drivers/block/cciss.c
> --- linux-2.6-p00004/drivers/block/cciss.c 2006-10-31 15:20:25.000000000 -0600
> +++ linux-2.6/drivers/block/cciss.c 2006-10-31 15:42:59.000000000 -0600
> @@ -2997,6 +2997,20 @@ static int cciss_pci_init(ctlr_info_t *c
> }
> #endif
>
> +#ifdef CONFIG_IA64
> + {
> + /* DMA prefetch must be disabled on P600 on platforms that may
> + * present noncontiguous memory.
> + */
> + __u32 dma_prefetch
> + if(board_id == 0x3225103C) {
> + dma_prefetch = readl(c->vaddr + I2O_DMA1_CFG);
> + dma_prefetch |= 0x8000;
> + writel(dma_prefetch, c->vaddr + I2O_DMA1_CFG);
> + }
> + }
> +#endif /* CONFIG_IA64 */
Hmm, what about other platforms with discontig memory support?
--
Jens Axboe
prev parent reply other threads:[~2006-11-02 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 22:06 [PATCH 5/8] cciss: disable DMA prefetch for P600 Mike Miller (OS Dev)
2006-11-02 14:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061102141213.GJ13555@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.