From: Ivo van Doorn <ivdoorn@gmail.com>
To: rt2400-devel@lists.sourceforge.net
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
John Linville <linville@tuxdriver.com>,
flamingice@sourmilk.net, Stefano Brivio <st3@riseup.net>,
Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de
Subject: Re: [Rt2400-devel] [PATCH 4/4] rt2x00-d80211: Add wireless statistics (compile tested only)
Date: Thu, 2 Nov 2006 20:10:30 +0100 [thread overview]
Message-ID: <200611022010.30463.IvDoorn@gmail.com> (raw)
In-Reply-To: <454A3D6B.mail4SV1NEUKH@lwfinger.net>
On Thursday 02 November 2006 19:48, Larry Finger wrote:
> These patches modify the rt2x00-d80211 family of drivers to use
> the wireless statics added in patch 1.
>
> Signed-Off-By: Larry Finger@lwfinger.net>
I will put the search for the correct values on my TODO list,
but that needs some heavy legacy driver research.
But these values seem sane enough for me. ;)
Signed-Off-By: Ivo van Doorn <IvDoorn@gmail.com>
> Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
> +++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
> @@ -1695,6 +1695,14 @@ static void rt2400pci_rxdone(void *data)
> rt2x00dev->rx_params.ssi =
> rt2x00_get_field32(rxd->word2, RXD_W2_RSSI);
>
> +/* FIXME: The following set of assignments supply additional data for wireless statistics. The
> + necessary quantities are (1) the "noise" value in dBm, and (2) the "signal" value in dBm.
> + The present code supplies dummy values for these quantities. */
> +
> + rt2x00dev->rx_params.noise = -85; /* FIXME */
> + rt2x00dev->rx_params.signal =
> + rt2x00dev->rx_params.ssi - RT2X00_RX_MAX_SSI; /* FIXME */
> +
> __ieee80211_rx(ring->net_dev,
> skb, &rt2x00dev->rx_params);
> }
> @@ -2581,6 +2589,7 @@ static int rt2400pci_init_hw(struct rt2x
> hw->device_strips_mic = 0;
> hw->monitor_during_oper = 1;
> hw->fraglist = 0;
> + hw->maxssi = RT2X00_RX_MAX_SSI;
>
> /*
> * We have 2 TX queues: TX and PRIO.
> Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
> +++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
> @@ -1841,6 +1841,14 @@ static void rt2500pci_rxdone(void *data)
> rt2x00dev->rx_params.ssi =
> rt2x00_get_field32(rxd->word2, RXD_W2_RSSI);
>
> +/* FIXME: The following set of assignments supply additional data for wireless statistics. The
> + necessary quantities are (1) the "noise" value in dBm, and (2) the "signal" value in dBm.
> + The present code supplies dummy values for these quantities. */
> +
> + rt2x00dev->rx_params.noise = -85; /* FIXME */
> + rt2x00dev->rx_params.signal =
> + rt2x00dev->rx_params.ssi - RT2X00_RX_MAX_SSI; /* FIXME */
> +
> __ieee80211_rx(ring->net_dev,
> skb, &rt2x00dev->rx_params);
>
> @@ -2735,6 +2743,7 @@ static int rt2500pci_init_hw(struct rt2x
> hw->device_strips_mic = 0;
> hw->monitor_during_oper = 1;
> hw->fraglist = 0;
> + hw->maxssi = RT2X00_RX_MAX_SSI;
>
> /*
> * We have 2 TX queues: TX and PRIO.
> Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2500usb.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt2500usb.c
> +++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2500usb.c
> @@ -1627,6 +1627,14 @@ static void rt2500usb_rxdone(void *data)
> rt2x00dev->rx_params.ssi =
> rt2x00_get_field32(rxd->word1, RXD_W1_RSSI);
>
> +/* FIXME: The following set of assignments supply additional data for wireless statistics. The
> + necessary quantities are (1) the "noise" value in dBm, and (2) the "signal" value in dBm.
> + The present code supplies dummy values for these quantities. */
> +
> + rt2x00dev->rx_params.noise = -85; /* FIXME */
> + rt2x00dev->rx_params.signal =
> + rt2x00dev->rx_params.ssi - RT2X00_RX_MAX_SSI; /* FIXME */
> +
> __ieee80211_rx(ring->net_dev,
> skb, &rt2x00dev->rx_params);
>
> @@ -2423,6 +2431,7 @@ static int rt2500usb_init_hw(struct rt2x
> hw->device_strips_mic = 0;
> hw->monitor_during_oper = 1;
> hw->fraglist = 0;
> + hw->maxssi = RT2X00_RX_MAX_SSI;
>
> /*
> * We have 2 TX queues: TX and PRIO.
> Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2x00.h
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt2x00.h
> +++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2x00.h
> @@ -850,6 +850,8 @@ struct rt2x00_dev {
> #define CONFIG_DOUBLE_ANTENNA 0x00010000
> #define CONFIG_DISABLE_BBP_TUNING 0x00020000
>
> +#define RT2X00_RX_MAX_SSI 100
> +
> /*
> * Chipset identification.
> */
> Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt61pci.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt61pci.c
> +++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt61pci.c
> @@ -2285,6 +2285,14 @@ static void rt61pci_rxdone(void *data)
> rt2x00dev->rx_params.ssi =
> rt2x00_get_field32(rxd->word1, RXD_W1_RSSI);
>
> +/* FIXME: The following set of assignments supply additional data for wireless statistics. The
> + necessary quantities are (1) the "noise" value in dBm, and (2) the "signal" value in dBm.
> + The present code supplies dummy values for these quantities. */
> +
> + rt2x00dev->rx_params.noise = -85; /* FIXME */
> + rt2x00dev->rx_params.signal =
> + rt2x00dev->rx_params.ssi - RT2X00_RX_MAX_SSI; /* FIXME */
> +
> __ieee80211_rx(ring->net_dev,
> skb, &rt2x00dev->rx_params);
>
> @@ -3255,6 +3263,7 @@ static int rt61pci_init_hw(struct rt2x00
> hw->device_strips_mic = 0;
> hw->monitor_during_oper = 1;
> hw->fraglist = 0;
> + hw->maxssi = RT2X00_RX_MAX_SSI;
>
> /*
> * We have full WMM capabilities.
> Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt73usb.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt73usb.c
> +++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt73usb.c
> @@ -1917,6 +1917,14 @@ static void rt73usb_rxdone(void *data)
> rt2x00dev->rx_params.ssi =
> rt2x00_get_field32(rxd->word1, RXD_W1_RSSI);
>
> +/* FIXME: The following set of assignments supply additional data for wireless statistics. The
> + necessary quantities are (1) the "noise" value in dBm, and (2) the "signal" value in dBm.
> + The present code supplies dummy values for these quantities. */
> +
> + rt2x00dev->rx_params.noise = -85; /* FIXME */
> + rt2x00dev->rx_params.signal =
> + rt2x00dev->rx_params.ssi - RT2X00_RX_MAX_SSI; /* FIXME */
> +
> __ieee80211_rx(ring->net_dev,
> skb, &rt2x00dev->rx_params);
>
> @@ -2796,6 +2804,7 @@ static int rt73usb_init_hw(struct rt2x00
> hw->device_strips_mic = 0;
> hw->monitor_during_oper = 1;
> hw->fraglist = 0;
> + hw->maxssi = RT2X00_RX_MAX_SSI;
>
> /*
> * We have full WMM capabilities.
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Rt2400-devel mailing list
> Rt2400-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/rt2400-devel
>
prev parent reply other threads:[~2006-11-02 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 18:48 [PATCH 4/4] rt2x00-d80211: Add wireless statistics (compile tested only) Larry Finger
2006-11-02 19:10 ` Ivo van Doorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611022010.30463.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=flamingice@sourmilk.net \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=rt2400-devel@lists.sourceforge.net \
--cc=st3@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.