From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 1/7] paravirtualization: header and stubs for paravirtualizing critical operations Date: Fri, 3 Nov 2006 03:56:53 +0100 Message-ID: <200611030356.54074.ak@suse.de> References: <20061029024504.760769000@sous-sol.org> <20061030231132.GA98768@muc.de> <1162376827.23462.5.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1162376827.23462.5.camel@localhost.localdomain> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.osdl.org Errors-To: virtualization-bounces@lists.osdl.org To: Rusty Russell Cc: Chris Wright , virtualization@lists.osdl.org, linux-kernel@vger.kernel.org, akpm@osdl.org List-Id: virtualization@lists.linuxfoundation.org T24gV2VkbmVzZGF5IDAxIE5vdmVtYmVyIDIwMDYgMTE6MjcsIFJ1c3R5IFJ1c3NlbGwgd3JvdGU6 Cj4gQ3JlYXRlIGEgcGFyYXZpcnQuaCBoZWFkZXIgZm9yIGFsbCB0aGUgY3JpdGljYWwgb3BlcmF0 aW9ucyB3aGljaCBuZWVkCj4gdG8gYmUgcmVwbGFjZWQgd2l0aCBoeXBlcnZpc29yIGNhbGxzLCBh bmQgaW5jbHVkZSB0aGF0IGluc3RlYWQgb2YKPiBkZWZpbmluZyBuYXRpdmUgb3BlcmF0aW9ucywg d2hlbiBDT05GSUdfUEFSQVZJUlQuCgpIbW0sIGRpZCB0aGlzIGFsbCBldmVyIGNvbXBpbGUgaW4g bWFpbmxpbmU/IEkgaGFkIHRvIGRvIGEgZmV3IG1lcmdlcwphbmQgaW4gdGhlIGVuZCBpIGdldAoK L2hvbWUvbHNyYy9xdWlsdC9saW51eC9rZXJuZWwvc3BpbmxvY2suYzogSW4gZnVuY3Rpb24g4oCY X3NwaW5fbG9ja19pcnFzYXZl4oCZOgppbmNsdWRlMi9hc20vc3BpbmxvY2suaDo1OTogZXJyb3I6 IGludmFsaWQgJ2FzbSc6IG9wZXJhbmQgbnVtYmVyIG1pc3NpbmcgYWZ0ZXIgJQotbGV0dGVyCmlu Y2x1ZGUyL2FzbS9zcGlubG9jay5oOjU5OiBlcnJvcjogaW52YWxpZCAnYXNtJzogb3BlcmFuZCBu dW1iZXIgbWlzc2luZyBhZnRlciAlCi1sZXR0ZXIKaW5jbHVkZTIvYXNtL3NwaW5sb2NrLmg6NTk6 IGVycm9yOiBpbnZhbGlkICdhc20nOiBvcGVyYW5kIG51bWJlciBtaXNzaW5nIGFmdGVyICUKLWxl dHRlcgppbmNsdWRlMi9hc20vc3BpbmxvY2suaDo1OTogZXJyb3I6IGludmFsaWQgJ2FzbSc6IG9w ZXJhbmQgbnVtYmVyIG1pc3NpbmcgYWZ0ZXIgJQotbGV0dGVyCmluY2x1ZGUyL2FzbS9zcGlubG9j ay5oOjU5OiBlcnJvcjogaW52YWxpZCAnYXNtJzogb3BlcmFuZCBudW1iZXIgbWlzc2luZyBhZnRl ciAlCi1sZXR0ZXIKaW5jbHVkZTIvYXNtL3NwaW5sb2NrLmg6NTk6IGVycm9yOiBpbnZhbGlkICdh c20nOiBvcGVyYW5kIG51bWJlciBtaXNzaW5nIGFmdGVyICUKLWxldHRlcgppbmNsdWRlMi9hc20v c3BpbmxvY2suaDo1OTogZXJyb3I6IGludmFsaWQgJ2FzbSc6IG9wZXJhbmQgbnVtYmVyIG1pc3Np bmcgYWZ0ZXIgJQotbGV0dGVyCmluY2x1ZGUyL2FzbS9zcGlubG9jay5oOjU5OiBlcnJvcjogaW52 YWxpZCAnYXNtJzogb3BlcmFuZCBudW1iZXIgbWlzc2luZyBhZnRlciAlCi1sZXR0ZXIKe3N0YW5k YXJkIGlucHV0fTogQXNzZW1ibGVyIG1lc3NhZ2VzOgp7c3RhbmRhcmQgaW5wdXR9OjU5MzogRXJy b3I6IHVuZGVmaW5lZCBzeW1ib2wgYHBhcmF2aXJ0X29wcycgaW4gb3BlcmF0aW9uCntzdGFuZGFy ZCBpbnB1dH06NTkzOiBFcnJvcjogdW5kZWZpbmVkIHN5bWJvbCBgUEFSQVZJUlRfaXJxX2VuYWJs ZScgaW4gb3BlcmF0aW9uCntzdGFuZGFyZCBpbnB1dH06NjA1OiBFcnJvcjogdW5kZWZpbmVkIHN5 bWJvbCBgcGFyYXZpcnRfb3BzJyBpbiBvcGVyYXRpb24Ke3N0YW5kYXJkIGlucHV0fTo2MDU6IEVy cm9yOiB1bmRlZmluZWQgc3ltYm9sIGBQQVJBVklSVF9pcnFfZGlzYWJsZScgaW4gb3BlcmF0aW8K bgoKYW5kIGxvdHMgb2YgbmV3IHdhcm5pbmdzIGxpa2UKCi9ob21lL2xzcmMvcXVpbHQvbGludXgv YXJjaC9pMzg2L2tlcm5lbC90cmFwcy5jOiBJbiBmdW5jdGlvbiDigJhzZXRfaW50cl9nYXRl4oCZ OgovaG9tZS9sc3JjL3F1aWx0L2xpbnV4L2FyY2gvaTM4Ni9rZXJuZWwvdHJhcHMuYzoxMTY1OiB3 YXJuaW5nOiBpbXBsaWNpdCBkZWNsYXJhdAppb24gb2YgZnVuY3Rpb24g4oCYX3NldF9nYXRl4oCZ Ci9ob21lL2xzcmMvcXVpbHQvbGludXgvYXJjaC9pMzg2L2tlcm5lbC9jcHUvY29tbW9uLmM6IElu IGZ1bmN0aW9uIOKAmF9jcHVfaW5pdOKAmToKL2hvbWUvbHNyYy9xdWlsdC9saW51eC9hcmNoL2kz ODYva2VybmVsL2NwdS9jb21tb24uYzo3NTQ6IHdhcm5pbmc6IGltcGxpY2l0IGRlY2wKYXJhdGlv biBvZiBmdW5jdGlvbiDigJhfX3NldF90c3NfZGVzY+KAmQovaG9tZS9sc3JjL3F1aWx0L2xpbnV4 L2FyY2gvaTM4Ni9rZXJuZWwvY3B1L21jaGVjay9wNC5jOiBJbiBmdW5jdGlvbiDigJhpbnRlbF9t YWNoCmluZV9jaGVja+KAmToKL2hvbWUvbHNyYy9xdWlsdC9saW51eC9hcmNoL2kzODYva2VybmVs L2NwdS9tY2hlY2svcDQuYzoxNTg6IHdhcm5pbmc6IOKAmGRiZy5lYXjigJkgCm1heSBiZSB1c2Vk IHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbgovaG9tZS9sc3JjL3F1aWx0L2xpbnV4L2Fy Y2gvaTM4Ni9rZXJuZWwvY3B1L21jaGVjay9wNC5jOjE1ODogd2FybmluZzog4oCYZGJnLmVieOKA mSAKbWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCBpbiB0aGlzIGZ1bmN0aW9uCi9ob21lL2xzcmMv cXVpbHQvbGludXgvYXJjaC9pMzg2L2tlcm5lbC9jcHUvbWNoZWNrL3A0LmM6MTU4OiB3YXJuaW5n OiDigJhkYmcuZWN44oCZIAptYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rp b24KL2hvbWUvbHNyYy9xdWlsdC9saW51eC9hcmNoL2kzODYva2VybmVsL2NwdS9tY2hlY2svcDQu YzoxNTg6IHdhcm5pbmc6IOKAmGRiZy5lZHjigJkgCm1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQg aW4gdGhpcyBmdW5jdGlvbgovaG9tZS9sc3JjL3F1aWx0L2xpbnV4L2FyY2gvaTM4Ni9rZXJuZWwv Y3B1L21jaGVjay9wNC5jOjE1ODogd2FybmluZzog4oCYZGJnLmVzaeKAmSAKbWF5IGJlIHVzZWQg dW5pbml0aWFsaXplZCBpbiB0aGlzIGZ1bmN0aW9uCi9ob21lL2xzcmMvcXVpbHQvbGludXgvYXJj aC9pMzg2L2tlcm5lbC9jcHUvbWNoZWNrL3A0LmM6MTU4OiB3YXJuaW5nOiDigJhkYmcuZWRp4oCZ IAptYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24KL2hvbWUvbHNyYy9x dWlsdC9saW51eC9hcmNoL2kzODYva2VybmVsL2NwdS9tY2hlY2svcDQuYzoxNTg6IHdhcm5pbmc6 IOKAmGRiZy5lYnDigJkgCm1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlv bgovaG9tZS9sc3JjL3F1aWx0L2xpbnV4L2FyY2gvaTM4Ni9rZXJuZWwvY3B1L21jaGVjay9wNC5j OjE1ODogd2FybmluZzog4oCYZGJnLmVzcOKAmSAKbWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCBp biB0aGlzIGZ1bmN0aW9uCi9ob21lL2xzcmMvcXVpbHQvbGludXgvYXJjaC9pMzg2L2tlcm5lbC9j cHUvbWNoZWNrL3A0LmM6MTU4OiB3YXJuaW5nOiDigJhkYmcuZWZsYWcKc+KAmSBtYXkgYmUgdXNl ZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24KL2hvbWUvbHNyYy9xdWlsdC9saW51eC9h cmNoL2kzODYva2VybmVsL2NwdS9tY2hlY2svcDQuYzoxNTg6IHdhcm5pbmc6IOKAmGRiZy5laXDi gJkgCm1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbgoKClRoaXMgaXMg d2l0aCBpMzg2IGRlZmNvbmZpZyArIENPTkZJR19QQVJBVklSVAoKLUFuZGkKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxp bmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5vc2RsLm9yZwpodHRwczovL2xpc3RzLm9zZGwu b3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbWKCC4y (ORCPT ); Thu, 2 Nov 2006 21:56:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752995AbWKCC4y (ORCPT ); Thu, 2 Nov 2006 21:56:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:56251 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1752994AbWKCC4y (ORCPT ); Thu, 2 Nov 2006 21:56:54 -0500 From: Andi Kleen To: Rusty Russell Subject: Re: [PATCH 1/7] paravirtualization: header and stubs for paravirtualizing critical operations Date: Fri, 3 Nov 2006 03:56:53 +0100 User-Agent: KMail/1.9.5 Cc: virtualization@lists.osdl.org, Chris Wright , akpm@osdl.org, linux-kernel@vger.kernel.org References: <20061029024504.760769000@sous-sol.org> <20061030231132.GA98768@muc.de> <1162376827.23462.5.camel@localhost.localdomain> In-Reply-To: <1162376827.23462.5.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200611030356.54074.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 01 November 2006 11:27, Rusty Russell wrote: > Create a paravirt.h header for all the critical operations which need > to be replaced with hypervisor calls, and include that instead of > defining native operations, when CONFIG_PARAVIRT. Hmm, did this all ever compile in mainline? I had to do a few merges and in the end i get /home/lsrc/quilt/linux/kernel/spinlock.c: In function ‘_spin_lock_irqsave’: include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after % -letter include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after % -letter include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after % -letter include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after % -letter include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after % -letter include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after % -letter include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after % -letter include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after % -letter {standard input}: Assembler messages: {standard input}:593: Error: undefined symbol `paravirt_ops' in operation {standard input}:593: Error: undefined symbol `PARAVIRT_irq_enable' in operation {standard input}:605: Error: undefined symbol `paravirt_ops' in operation {standard input}:605: Error: undefined symbol `PARAVIRT_irq_disable' in operatio n and lots of new warnings like /home/lsrc/quilt/linux/arch/i386/kernel/traps.c: In function ‘set_intr_gate’: /home/lsrc/quilt/linux/arch/i386/kernel/traps.c:1165: warning: implicit declarat ion of function ‘_set_gate’ /home/lsrc/quilt/linux/arch/i386/kernel/cpu/common.c: In function ‘_cpu_init’: /home/lsrc/quilt/linux/arch/i386/kernel/cpu/common.c:754: warning: implicit decl aration of function ‘__set_tss_desc’ /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c: In function ‘intel_mach ine_check’: /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.eax’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.ebx’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.ecx’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.edx’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.esi’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.edi’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.ebp’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.esp’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.eflag s’ may be used uninitialized in this function /home/lsrc/quilt/linux/arch/i386/kernel/cpu/mcheck/p4.c:158: warning: ‘dbg.eip’ may be used uninitialized in this function This is with i386 defconfig + CONFIG_PARAVIRT -Andi