From: Miguel Ojeda Sandonis <maxextreme@gmail.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH update7] drivers: add LCD support
Date: Sun, 5 Nov 2006 11:49:56 +0000 [thread overview]
Message-ID: <20061105114956.4257720b.maxextreme@gmail.com> (raw)
Andrew, 3 minor fixes for the drivers-add-lcd-support saga.
---
- cfag12864b_work should be static
- spelling
- coding style
drivers/auxdisplay/cfag12864b.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
miguelojeda-drivers-add-LCD-support-7-minor-fixes
Signed-off-by: Miguel Ojeda Sandonis <maxextreme@gmail.com>
---
diff -uprN -X dontdiff linux-mod4/drivers/auxdisplay/cfag12864b.c linux/drivers/auxdisplay/cfag12864b.c
--- linux-mod4/drivers/auxdisplay/cfag12864b.c 2006-11-01 19:49:47.000000000 +0000
+++ linux/drivers/auxdisplay/cfag12864b.c 2006-11-05 11:39:58.000000000 +0000
@@ -63,10 +63,10 @@ unsigned int cfag12864b_getrate(void)
* cfag12864b/ks0108 reads the command/data.
*
* CS1 = First ks0108controller.
- * If high, the first ks0108 receives commands/data.
+ * If high, the first ks0108 controller receives commands/data.
*
* CS2 = Second ks0108 controller
- * If high, the second ks0108 receives commands/data.
+ * If high, the second ks0108 controller receives commands/data.
*
* DI = Data/Instruction
* If low, cfag12864b will expect commands.
@@ -223,7 +223,7 @@ static DEFINE_MUTEX(cfag12864b_mutex);
static unsigned char cfag12864b_updating;
static void cfag12864b_update(void *arg);
static struct workqueue_struct *cfag12864b_workqueue;
-DECLARE_WORK(cfag12864b_work, cfag12864b_update, NULL);
+static DECLARE_WORK(cfag12864b_work, cfag12864b_update, NULL);
static void cfag12864b_queue(void)
{
@@ -241,8 +241,7 @@ unsigned char cfag12864b_enable(void)
cfag12864b_updating = 1;
cfag12864b_queue();
ret = 0;
- }
- else
+ } else
ret = 1;
mutex_unlock(&cfag12864b_mutex);
next reply other threads:[~2006-11-05 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-05 11:49 Miguel Ojeda Sandonis [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-06 20:24 [PATCH update7] drivers: add LCD support Miguel Ojeda Sandonis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061105114956.4257720b.maxextreme@gmail.com \
--to=maxextreme@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.