diff for duplicates of <200611060045.59074.arnd@arndb.de> diff --git a/a/1.txt b/N1/1.txt index ceeede8..bbb9e85 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,16 +8,16 @@ On Sunday 05 November 2006 21:40, Hoang-Nam Nguyen wrote: > + > +void *ehca_alloc_fw_ctrlblock(void) > +{ -> + void *ret =3D kmem_cache_alloc(ctblk_cache, SLAB_KERNEL); +> + void *ret = kmem_cache_alloc(ctblk_cache, SLAB_KERNEL); > + if (!ret) -> + =A0ehca_gen_err("Out of memory for ctblk"); +> + ehca_gen_err("Out of memory for ctblk"); > + return ret; > +} > + > +void ehca_free_fw_ctrlblock(void *ptr) > +{ > + if (ptr) -> + =A0kmem_cache_free(ctblk_cache, ptr); +> + kmem_cache_free(ctblk_cache, ptr); > + This seems broken. You have a constructor for newly allocated objects, but diff --git a/a/content_digest b/N1/content_digest index 31e954e..6e92c51 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,10 @@ "Subject\0Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode\0" "Date\0Mon, 6 Nov 2006 00:45:58 +0100\0" "To\0linuxppc-dev@ozlabs.org\0" - "Cc\0linux-kernel@vger.kernel.org" + "Cc\0Hoang-Nam Nguyen <hnguyen@de.ibm.com>" + rolandd@cisco.com raisch@de.ibm.com + linux-kernel@vger.kernel.org " openib-general@openib.org\0" "\00:1\0" "b\0" @@ -18,16 +20,16 @@ "> +\n" "> +void *ehca_alloc_fw_ctrlblock(void)\n" "> +{\n" - "> + void *ret =3D kmem_cache_alloc(ctblk_cache, SLAB_KERNEL);\n" + "> + void *ret = kmem_cache_alloc(ctblk_cache, SLAB_KERNEL);\n" "> + if (!ret)\n" - "> + =A0ehca_gen_err(\"Out of memory for ctblk\");\n" + "> + \302\240ehca_gen_err(\"Out of memory for ctblk\");\n" "> + return ret;\n" "> +}\n" "> +\n" "> +void ehca_free_fw_ctrlblock(void *ptr)\n" "> +{\n" "> + if (ptr)\n" - "> + =A0kmem_cache_free(ctblk_cache, ptr);\n" + "> + \302\240kmem_cache_free(ctblk_cache, ptr);\n" "> +\n" "\n" "This seems broken. You have a constructor for newly allocated objects, but\n" @@ -39,4 +41,4 @@ "\n" "\tArnd <><" -3db9faf4e403c883ff4ce8cc30506c5a7cfd2472ac8f8ae092398e1fc0d021f9 +5168cccc7346fa458b05f8da70a499db78df9ddbfecd4658297cdcde682d33ed
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.