From: Oleg Nesterov <oleg@tv-sign.ru>
To: David Howells <dhowells@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] a minor fix for set_mb() in Documentation/memory-barriers.txt
Date: Mon, 6 Nov 2006 18:03:29 +0300 [thread overview]
Message-ID: <20061106150329.GA226@oleg> (raw)
set_mb() is used by set_current_state() which needs mb(), not wmb().
I think it would be right to assume that set_mb() implies mb(), all
arches seem to do just this.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- d/Documentation/memory-barriers.txt~ 2006-11-06 17:43:36.000000000 +0300
+++ d/Documentation/memory-barriers.txt 2006-11-06 17:44:26.000000000 +0300
@@ -1016,7 +1016,7 @@ There are some more advanced barrier fun
(*) set_mb(var, value)
- This assigns the value to the variable and then inserts at least a write
+ This assigns the value to the variable and then inserts a full memory
barrier after it, depending on the function. It isn't guaranteed to
insert anything more than a compiler barrier in a UP compilation.
next reply other threads:[~2006-11-06 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 15:03 Oleg Nesterov [this message]
2006-11-08 11:29 ` [PATCH] a minor fix for set_mb() in Documentation/memory-barriers.txt David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061106150329.GA226@oleg \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.