From: Jens Axboe <jens.axboe@oracle.com>
To: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 6/12] repost: cciss: set sector_size to 2048 for performance
Date: Mon, 6 Nov 2006 21:30:02 +0100 [thread overview]
Message-ID: <20061106203001.GF19471@kernel.dk> (raw)
In-Reply-To: <20061106202055.GF17847@beardog.cca.cpqcorp.net>
On Mon, Nov 06 2006, Mike Miller (OS Dev) wrote:
> PATCH 6/11
>
> This patch changes the blk_queue_max_sectors from 512 to 2048. This helps
> increase performance.
> Please consider this for inclusion.
Bad naming - I've never seen sector size refer to anything else but the
actual sector size on the device. Here you use it as the largest
supported command size. To make matters worse, you also export it in the
proc file as such, that's certain to confuse users.
In other news, ack on patch 1-5 so far.
--
Jens Axboe
prev parent reply other threads:[~2006-11-06 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 20:20 [PATCH 6/12] repost: cciss: set sector_size to 2048 for performance Mike Miller (OS Dev)
2006-11-06 20:30 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061106203001.GF19471@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.