All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dave Jones <davej@redhat.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Sergio Monteiro Basto <sergio@sergiomb.no-ip.org>,
	akpm@osdl.org, Wilco Beekhuizen <wilcobeekhuizen@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: VIA IRQ quirk missing PCI ids since 2.6.16.17
Date: Tue, 7 Nov 2006 13:07:44 +0900	[thread overview]
Message-ID: <20061107040744.GA23641@kroah.com> (raw)
In-Reply-To: <20061107012519.GC25719@redhat.com>

On Mon, Nov 06, 2006 at 08:25:19PM -0500, Dave Jones wrote:
> On Mon, Nov 06, 2006 at 09:13:45PM +0000, Alan Cox wrote:
> 
>  > +static const struct pci_device_id via_vlink_fixup_tbl[] = {
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233_0), 17},
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233A), 17 },
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233C_0), 17 },
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8235), 16 },
>  > +	/* May not be needed for the 8237 */
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8237), 15 },
>  > +	{ PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8237A), 15 },
>  >  	{ 0, },
> 
> This got me wondering what PCI_VDEVICE was, so I went looking.
> It's a libata'ism it seems with the comment..
> 
> /* move to PCI layer? */

I have no objection to moving this to pci.h.  Feel free to send me a
patch.

thanks,

greg k-h

  parent reply	other threads:[~2006-11-07  4:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06 11:38 VIA IRQ quirk missing PCI ids since 2.6.16.17 Wilco Beekhuizen
2006-11-06 12:47 ` Sergio Monteiro Basto
2006-11-06 21:13   ` Alan Cox
2006-11-07  1:25     ` Dave Jones
2006-11-07  1:34       ` Alan Cox
2006-11-08  8:54         ` Wilco Beekhuizen
2006-11-08 12:43           ` Sergio Monteiro Basto
2006-11-08 14:55             ` Wilco Beekhuizen
2006-11-08 15:19           ` Alan Cox
2006-11-07  4:07       ` Greg KH [this message]
2006-11-07  8:31       ` Jeff Garzik
2006-11-08 17:22     ` Sergey Vlasov
2006-11-08 18:05       ` Alan Cox
2006-11-08 20:33         ` Sergey Vlasov
2006-11-06 13:30 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061107040744.GA23641@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio@sergiomb.no-ip.org \
    --cc=wilcobeekhuizen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.