From: Alexander Viro <aviro@redhat.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: Mark Workman <mworkman@linus.mitre.org>, linux-audit@redhat.com
Subject: Re: [PATCH 2.6.19-rc4] audit: support for descriptor pairs (fwd)
Date: Tue, 7 Nov 2006 13:31:57 -0500 [thread overview]
Message-ID: <20061107183157.GJ25857@devserv.devel.redhat.com> (raw)
In-Reply-To: <200611070858.20720.sgrubb@redhat.com>
On Tue, Nov 07, 2006 at 08:58:20AM -0500, Steve Grubb wrote:
> On Tuesday 07 November 2006 08:18, Mark Workman wrote:
> > provide an audit record of the descriptor pair returned by pipe() and
> > socketpair().
>
> Patch looks OK to me. Al, what do you think?
Ehh...
a) why bother with exporting sock_map_... at all?
b) failure exits in socketpair are, AFAICS, botched by the
patch. At the very least, you can get sock_release() done on a socket
that already went through it due to fput(). Please, fix.
I would suggest taking that into sys_socketpair(), actually,
instead of a new helper...
prev parent reply other threads:[~2006-11-07 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 13:18 [PATCH 2.6.19-rc4] audit: support for descriptor pairs (fwd) Mark Workman
2006-11-07 13:58 ` Steve Grubb
2006-11-07 18:31 ` Alexander Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107183157.GJ25857@devserv.devel.redhat.com \
--to=aviro@redhat.com \
--cc=linux-audit@redhat.com \
--cc=mworkman@linus.mitre.org \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.