From: Andrew Morton <akpm@osdl.org>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: ak@suse.de, shaohua.li@intel.com, linux-kernel@vger.kernel.org,
discuss@x86-64.org, ashok.raj@intel.com
Subject: Re: [patch 0/4] i386, x86_64: fix the irqbalance quirk for E7520/E7320/E7525
Date: Tue, 7 Nov 2006 20:07:02 -0800 [thread overview]
Message-ID: <20061107200702.8abac851.akpm@osdl.org> (raw)
In-Reply-To: <20061107173306.C3262@unix-os.sc.intel.com>
On Tue, 7 Nov 2006 17:33:06 -0800
"Siddha, Suresh B" <suresh.b.siddha@intel.com> wrote:
> Mechanism of selecting physical mode in genapic when cpu hotplug is enabled
> on x86_64, broke the quirk(quirk_intel_irqbalance()) introduced for working
> around the transposing interrupt message errata in E7520/E7320/E7525
> (revision ID 0x9 and below. errata #23 in
> http://download.intel.com/design/chipsets/specupdt/30304203.pdf).
>
> This errata requires the mode to be in logical flat, so that interrupts
> can be directed to more than one cpu(and thus use hardware IRQ balancing
> enabled by BIOS on these platforms).
>
> Following four patches fixes this by moving the quirk to early quirk
> and forcing the x86_64 genapic selection to logical flat on these platforms.
>
> Thanks to Shaohua for pointing out the breakage.
It blew up with the first config I tried
(http://userweb.kernel.org/~akpm/config-vmm.txt):
arch/i386/kernel/built-in.o: In function `verify_quirk_intel_irqbalance':
arch/i386/kernel/quirks.c:19: undefined reference to `genapic'
arch/i386/kernel/quirks.c:19: undefined reference to `apic_default'
arch/i386/kernel/built-in.o: In function `__cpu_up':
arch/i386/kernel/smpboot.c:1487: undefined reference to `genapic'
arch/i386/kernel/smpboot.c:1487: undefined reference to `apic_default'
The dependencies in the code which you're touching here are really really
complex and fragile. One needs to review the change very carefully and
test it exhaustively.
next prev parent reply other threads:[~2006-11-08 4:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 1:33 [patch 0/4] i386, x86_64: fix the irqbalance quirk for E7520/E7320/E7525 Siddha, Suresh B
2006-11-08 1:36 ` [patch 1/4] add write_pci_config_byte() to direct PCI access routines Siddha, Suresh B
2006-11-08 1:40 ` [patch 2/4] introduce the mechanism of disabling cpu hotplug control Siddha, Suresh B
2006-11-08 1:43 ` [patch 3/4] x86_64: add genapic_force Siddha, Suresh B
2006-11-08 1:46 ` [patch 4/4] fix the irqbalance quirk for E7320/E7520/E7525 Siddha, Suresh B
2006-11-08 3:54 ` [patch 2/4] introduce the mechanism of disabling cpu hotplug control Andrew Morton
2006-11-08 4:01 ` Siddha, Suresh B
2006-11-08 4:35 ` Andrew Morton
2006-11-08 5:23 ` Siddha, Suresh B
2006-11-11 0:43 ` [patch] change the 'no_control' field to 'hotpluggable' in the struct cpu Siddha, Suresh B
2006-11-08 4:07 ` Andrew Morton [this message]
2006-11-08 4:06 ` [patch 0/4] i386, x86_64: fix the irqbalance quirk for E7520/E7320/E7525 Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107200702.8abac851.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=ashok.raj@intel.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.