From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Layton <jlayton@redhat.com>
Cc: J?rn Engel <joern@wohnheim.fh-wedel.de>,
Eric Sandeen <sandeen@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability
Date: Tue, 7 Nov 2006 14:20:12 -0700 [thread overview]
Message-ID: <20061107212012.GC27140@parisc-linux.org> (raw)
In-Reply-To: <1162933980.28425.64.camel@dantu.rdu.redhat.com>
On Tue, Nov 07, 2006 at 04:13:00PM -0500, Jeff Layton wrote:
> + /* ino must not collide with any ino assigned in the loop below. Set
> + it to the highest possible inode number */
> + inode->i_ino = (1 << (sizeof(s->s_lastino) * 8)) - 1;
This really isn't a good idiom to be using; GCC now takes this to mean
"I can reformat your hard drive because you did something outside the
spec".
Try instead:
+ inode->i_ino = -1;
next prev parent reply other threads:[~2006-11-07 21:20 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 18:12 [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability Jeff Layton
2006-11-06 18:22 ` Matthew Wilcox
2006-11-06 18:31 ` Jeff Layton
2006-11-06 18:47 ` Jeff Layton
2006-11-06 20:23 ` Jörn Engel
2006-11-06 20:23 ` Jörn Engel
2006-11-06 20:31 ` Eric Dumazet
2006-11-06 20:31 ` Eric Dumazet
2006-11-06 20:56 ` Jeff Layton
2006-11-06 20:50 ` Eric Sandeen
2006-11-06 20:50 ` Eric Sandeen
2006-11-06 21:11 ` Jörn Engel
2006-11-06 21:36 ` Eric Sandeen
2006-11-06 21:36 ` Eric Sandeen
2006-11-06 22:01 ` Andreas Dilger
2006-11-07 15:56 ` Jeff Layton
2006-11-07 16:07 ` Jeff Layton
2006-11-07 16:10 ` Matthew Wilcox
2006-11-07 17:04 ` Jörn Engel
2006-11-07 17:04 ` Jörn Engel
2006-11-07 17:28 ` Jörn Engel
2006-11-07 17:28 ` Jörn Engel
2006-11-07 17:42 ` Jörn Engel
2006-11-07 17:42 ` Jörn Engel
2006-11-07 17:53 ` Dave Kleikamp
2006-11-07 17:53 ` Dave Kleikamp
2006-11-07 18:07 ` Jörn Engel
2006-11-07 18:07 ` Jörn Engel
2006-11-07 17:56 ` Jörn Engel
2006-11-07 17:56 ` Jörn Engel
2006-11-07 18:01 ` Jörn Engel
2006-11-07 18:10 ` Eric Sandeen
2006-11-07 18:10 ` Eric Sandeen
2006-11-07 19:41 ` Jeff Layton
2006-11-07 19:41 ` Jeff Layton
2006-11-07 20:41 ` Jörn Engel
2006-11-07 20:41 ` Jörn Engel
2006-11-07 21:13 ` Jeff Layton
2006-11-07 21:13 ` Jeff Layton
2006-11-07 21:20 ` Matthew Wilcox [this message]
2006-11-07 22:09 ` Jeff Layton
2006-11-07 18:01 ` Jeff Layton
2006-11-07 18:14 ` Jörn Engel
2006-11-07 18:14 ` Jörn Engel
2006-11-07 18:23 ` Jeff Layton
2006-11-07 18:23 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107212012.GC27140@parisc-linux.org \
--to=matthew@wil.cx \
--cc=jlayton@redhat.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.