From: Dave Jones <davej@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gx-suspmod: fix "&& 0xff" typo
Date: Wed, 8 Nov 2006 17:11:07 -0500 [thread overview]
Message-ID: <20061108221106.GG3309@redhat.com> (raw)
In-Reply-To: <20061108220435.GA4972@martell.zuzino.mipt.ru>
On Thu, Nov 09, 2006 at 01:04:35AM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> +++ b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> @@ -473,7 +473,7 @@ static int __init cpufreq_gx_init(void)
> pci_read_config_byte(params->cs55x0, PCI_MODON, &(params->on_duration));
> pci_read_config_byte(params->cs55x0, PCI_MODOFF, &(params->off_duration));
> pci_read_config_dword(params->cs55x0, PCI_CLASS_REVISION, &class_rev);
> - params->pci_rev = class_rev && 0xff;
> + params->pci_rev = class_rev & 0xff;
>
> if ((ret = cpufreq_register_driver(&gx_suspmod_driver))) {
> kfree(params);
Ouch, good catch. applied.
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2006-11-08 22:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 22:04 [PATCH] gx-suspmod: fix "&& 0xff" typo Alexey Dobriyan
2006-11-08 22:10 ` Randy Dunlap
2006-11-08 22:16 ` Dave Jones
2006-11-08 22:20 ` Alexey Dobriyan
2006-11-08 22:50 ` Dave Jones
2006-11-09 4:24 ` Willy Tarreau
2006-11-10 20:16 ` Horst H. von Brand
2006-11-08 22:11 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061108221106.GG3309@redhat.com \
--to=davej@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.