From: Stephen Hemminger <shemminger@osdl.org>
To: jim@jklewis.com
Cc: Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
netdev <netdev@vger.kernel.org>, Work <jklewis@us.ibm.com>
Subject: Re: [PATCH] Spidernet - remove ETH_ZLEN check in earlier patch
Date: Fri, 10 Nov 2006 09:58:02 -0800 [thread overview]
Message-ID: <20061110095802.26854fea@freekitty> (raw)
In-Reply-To: <1163181046.4422.11.camel@localhost.localdomain>
On Fri, 10 Nov 2006 11:50:46 -0600
Jim Lewis <jim@jklewis.com> wrote:
> Subject: Spidernet - remove ETH_ZLEN check in earlier patch
> From: James K Lewis <jklewis@us.ibm.com>
>
> In an earlier patch, code was added to pad packets that were less that
> ETH_ZLEN (60) bytes using the skb_pad function. This has caused hangs
> when accessing certain NFS mounted file systems. This patch removes the
> check and solves the NFS problem. The driver, with this patch, has been
> tested extensively. Please apply.
>
>
> Signed-off-by: James K Lewis <jklewis@us.ibm.com>
Does the hardware do padding for you? The padding is important for the Ethernet
spec, and for security reasons (random memory leakage).
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-11-10 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 17:50 [PATCH] Spidernet - remove ETH_ZLEN check in earlier patch Jim Lewis
2006-11-10 17:58 ` Stephen Hemminger [this message]
2006-11-10 18:50 ` [PATCH] spidernet: fix transmit routine Stephen Hemminger
[not found] ` <OFF9C5DB9C.8DD003F3-ON87257222.0068A615-86257222.006950CA@us.ibm.com>
2006-11-10 19:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110095802.26854fea@freekitty \
--to=shemminger@osdl.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=jim@jklewis.com \
--cc=jklewis@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.