From: Alan Cox <alan@redhat.com>
To: Alexey Dobriyan <adobriyan@openvz.org>
Cc: Andrew Morton <akpm@osdl.org>, Alan Cox <alan@redhat.com>,
linux-ide@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH] pata_artop: fix "& (1 >>" typo
Date: Fri, 10 Nov 2006 11:25:35 -0500 [thread overview]
Message-ID: <20061110162535.GA7338@devserv.devel.redhat.com> (raw)
In-Reply-To: <20061110195246.GC5872@localhost.sw.ru>
On Fri, Nov 10, 2006 at 10:52:46PM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
Acked-by: Alan Cox <alan@redhat.com>
> ---
>
> drivers/ata/pata_artop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -92,7 +92,7 @@ static int artop6260_pre_reset(struct at
> return -ENOENT;
>
> pci_read_config_byte(pdev, 0x49, &tmp);
> - if (tmp & (1 >> ap->port_no))
> + if (tmp & (1 << ap->port_no))
> ap->cbl = ATA_CBL_PATA40;
> else
> ap->cbl = ATA_CBL_PATA80;
--
"People who choose variable names like htlbpagek SHOULD be sent to
produce a street map of R'Lyeh. On site."
-- Al Viro
next prev parent reply other threads:[~2006-11-10 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 19:52 [PATCH] pata_artop: fix "& (1 >>" typo Alexey Dobriyan
2006-11-10 16:25 ` Alan Cox [this message]
2006-11-14 14:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110162535.GA7338@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=adobriyan@openvz.org \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.