From: David Miller <davem@davemloft.net>
To: eric.lemoine@gmail.com
Cc: netdev@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [patch sungem] improved locking
Date: Mon, 13 Nov 2006 23:44:56 -0800 (PST) [thread overview]
Message-ID: <20061113.234456.78492515.davem@davemloft.net> (raw)
In-Reply-To: <5cac192f0611132328i52d6d615g28d8c493dc028621@mail.gmail.com>
From: "Eric Lemoine" <eric.lemoine@gmail.com>
Date: Tue, 14 Nov 2006 08:28:42 +0100
> because it makes it explicit that only bits 0 through 6 are taken into
> account when writing the IACK register.
The phrase "bits 0 through 6" doesn't make any sense when bit 3 DOES
NOT EXIST in the hardware, it's reserved, it's not there, so including
it only confuses people and obfuscates the code.
Please use the explicit bit mask composed of existing macros, which
not only makes sure that the mask has meaning, but it also makes sure
that reserved and non-existing bits are never referenced.
next prev parent reply other threads:[~2006-11-14 7:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 21:33 [patch sungem] improved locking Eric Lemoine
2006-11-09 23:04 ` David Miller
2006-11-10 13:28 ` Eric Lemoine
2006-11-10 20:37 ` Benjamin Herrenschmidt
2006-11-10 20:42 ` David Miller
2006-11-12 23:11 ` Eric Lemoine
2006-11-14 0:46 ` David Miller
2006-11-14 7:28 ` Eric Lemoine
2006-11-14 7:44 ` David Miller [this message]
2006-11-14 21:54 ` Eric Lemoine
2006-11-28 22:49 ` David Miller
2006-11-28 22:57 ` Benjamin Herrenschmidt
2006-11-28 23:43 ` David Miller
2006-11-29 0:19 ` Benjamin Herrenschmidt
2006-11-29 10:16 ` Eric Lemoine
2006-11-29 10:56 ` Eric Lemoine
2006-11-29 22:37 ` Eric Lemoine
2006-12-13 3:12 ` Benjamin Herrenschmidt
2006-12-13 3:24 ` Benjamin Herrenschmidt
2006-12-13 4:03 ` David Miller
2006-12-13 4:07 ` Benjamin Herrenschmidt
2006-12-29 5:05 ` David Miller
2006-12-29 21:36 ` Benjamin Herrenschmidt
2006-12-29 23:20 ` David Miller
2006-12-12 1:43 ` David Miller
2006-12-12 5:33 ` Eric Lemoine
2006-12-12 5:36 ` Benjamin Herrenschmidt
2006-12-12 5:49 ` Eric Lemoine
2006-12-15 0:59 ` Benjamin Herrenschmidt
2006-12-18 1:15 ` David Miller
2006-12-18 1:41 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061113.234456.78492515.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=eric.lemoine@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.