From: Olof Johansson <olof@lixom.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [POWERPC] iSeries: fix slb.c for combined build
Date: Mon, 13 Nov 2006 01:03:30 -0600 [thread overview]
Message-ID: <20061113010330.1d821876@pb15> (raw)
In-Reply-To: <20061113144918.84647810.sfr@canb.auug.org.au>
On Mon, 13 Nov 2006 14:49:18 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> -#ifndef CONFIG_PPC_ISERIES
> - {
> - unsigned long lflags, vflags;
> + if (!firmware_has_feature(FW_FEATURE_ISERIES)) {
> + unsigned long lflags, vflags;
>
> - lflags = SLB_VSID_KERNEL | linear_llp;
It'll be a little tidier if you move the stab_rr setting (common code
at the bottom of the function) up above the test, and just return early
for iseries, instead of indenting everything an extra level.
-Olof
next prev parent reply other threads:[~2006-11-13 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 3:49 [POWERPC] iSeries: fix slb.c for combined build Stephen Rothwell
2006-11-13 7:03 ` Olof Johansson [this message]
2006-11-14 1:57 ` Stephen Rothwell
2006-11-14 2:03 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061113010330.1d821876@pb15 \
--to=olof@lixom.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.