From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Mon, 13 Nov 2006 21:32:17 +0000 Subject: [Cluster-devel] Re: [PATCH 1/2] GFS2: struct gfs2_rindex vs char buf[] cleanup In-Reply-To: <20061113205531.GB4971@martell.zuzino.mipt.ru> References: <20061113205531.GB4971@martell.zuzino.mipt.ru> Message-ID: <20061113213217.GU29920@ftp.linux.org.uk> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Nov 13, 2006 at 11:55:31PM +0300, Alexey Dobriyan wrote: > Looks like the following code is needed to just save a cast: > > char buf[sizeof(struct gfs2_rindex)]; > > Name things by their names. Also, patch will make endian annotations > more complete. Is that against mainline or against gfs2 tree? The later has a pile of endianness annotations in it... From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 1/2] GFS2: struct gfs2_rindex vs char buf[] cleanup Date: Mon, 13 Nov 2006 21:32:17 +0000 Message-ID: <20061113213217.GU29920@ftp.linux.org.uk> References: <20061113205531.GB4971@martell.zuzino.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Steven Whitehouse , cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:6813 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S933068AbWKMVcT (ORCPT ); Mon, 13 Nov 2006 16:32:19 -0500 To: Alexey Dobriyan Content-Disposition: inline In-Reply-To: <20061113205531.GB4971@martell.zuzino.mipt.ru> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Nov 13, 2006 at 11:55:31PM +0300, Alexey Dobriyan wrote: > Looks like the following code is needed to just save a cast: > > char buf[sizeof(struct gfs2_rindex)]; > > Name things by their names. Also, patch will make endian annotations > more complete. Is that against mainline or against gfs2 tree? The later has a pile of endianness annotations in it...