All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: [PATCH 1/5] [POWERPC] 8xx: platform-specific mmu updates
Date: Tue, 14 Nov 2006 04:28:12 +0300	[thread overview]
Message-ID: <20061114012812.17455.32840.stgit@localhost.localdomain> (raw)
In-Reply-To: <20061114012504.17455.13833.stgit@localhost.localdomain>


This is just a straight port of the same done in arch/ppc
by Marcelo Tosatti. One used to be
[PATCH] ppc32 8xx: update_mmu_cache() needs unconditional tlbie,
commit eb07d964b4491d1bb5864cd3d7e7633ccdda9a53

Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
---

 arch/powerpc/mm/mem.c |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index d1c0758..c85eda6 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -490,19 +490,19 @@ #endif
 	    !cpu_has_feature(CPU_FTR_NOEXECUTE) &&
 	    pfn_valid(pfn)) {
 		struct page *page = pfn_to_page(pfn);
+#ifdef CONFIG_8xx
+		/* On 8xx, cache control instructions (particularly
+		 * "dcbst" from flush_dcache_icache) fault as write
+		 * operation if there is an unpopulated TLB entry
+		 * for the address in question. To workaround that,
+		 * we invalidate the TLB here, thus avoiding dcbst
+		 * misbehaviour.
+		 */
+		_tlbie(address);
+#endif
 		if (!PageReserved(page)
 		    && !test_bit(PG_arch_1, &page->flags)) {
 			if (vma->vm_mm == current->active_mm) {
-#ifdef CONFIG_8xx
-			/* On 8xx, cache control instructions (particularly 
-		 	 * "dcbst" from flush_dcache_icache) fault as write 
-			 * operation if there is an unpopulated TLB entry 
-			 * for the address in question. To workaround that, 
-			 * we invalidate the TLB here, thus avoiding dcbst 
-			 * misbehaviour.
-			 */
-				_tlbie(address);
-#endif
 				__flush_dcache_icache((void *) address);
 			} else
 				flush_dcache_icache_page(page);

       reply	other threads:[~2006-11-14  1:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061114012504.17455.13833.stgit@localhost.localdomain>
2006-11-14  1:28 ` Vitaly Bordug [this message]
2006-11-14  1:28 ` [PATCH 2/5] [POWERPC] 8xx: generic 8xx code arch/powerpc port Vitaly Bordug
2006-11-15 18:23   ` Christoph Hellwig
2006-11-15 23:36     ` Vitaly Bordug
2006-11-16 22:48     ` Benjamin Herrenschmidt
2006-11-17  6:49       ` Christoph Hellwig
2006-11-17  8:00   ` Christoph Hellwig
2006-11-18  1:24     ` Dan Malek
2006-11-20 10:24       ` Christoph Hellwig
2006-11-21  0:26         ` Dan Malek
2006-11-14  1:28 ` [PATCH 3/5] [POWERPC] 8xx: platform-related changes to the fsl_soc.c Vitaly Bordug
2006-11-14  2:21   ` Benjamin Herrenschmidt
2006-11-14 12:48     ` Vitaly Bordug
2006-11-14  1:28 ` [PATCH 4/5] [POWERPC] 8xx: powerpc port of core CPM, CPM PIC, etc Vitaly Bordug
2006-11-14  2:44   ` Benjamin Herrenschmidt
2006-11-14  1:28 ` [PATCH 5/5] [POWERPC] 8xx: Add mpc885ads support and common mpc8xx Vitaly Bordug
2006-11-14  2:47   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061114012812.17455.32840.stgit@localhost.localdomain \
    --to=vbordug@ru.mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.