Re: [RFC] [PATCH 10/16] x86_64: 64bit PIC ACPI wakeup

[Vivek Goyal <vgoyal@in.ibm.com>]

On Tue, Nov 14, 2006 at 04:30:03PM +0000, Pavel Machek wrote:
> Hi!
> 
> > - Killed lots of dead code
> > - Improve the cpu sanity checks to verify long mode
> >   is enabled when we wake up.
> > - Removed the need for modifying any existing kernel page table.
> > - Moved wakeup_level4_pgt into the wakeup routine so we can
> >   run the kernel above 4G.
> > - Increased the size of the wakeup routine to 8K.
> > - Renamed the variables to use the 64bit register names.
> > - Lots of misc cleanups to match trampoline.S
> > 
> > I don't have a configuration I can test this but it compiles cleanly
> 
> Ugh, now that's a big patch.. and untested, too :-(.
> 
> Why is PGE no longer required, for example?
> 
> Can we get it piece-by-piece?
> 
> > Vivek has tested this patch for suspend to memory and it works fine.
> 
> Ok, so it was tested on one config. Given that the patch deals with
> detecting CPU oddities... :-(

Hi Pavel,

This code has been lying in RHEL kernels for close to 3 months now.
Have not heard of suspend/resume complaints. So hoping it got
tested on wide variety of hardware too apart from testing on my machine.

Thanks
Vivek