From: Andi Kleen <ak@suse.de>
To: patches@x86-64.org
Cc: Hugh Dickins <hugh@veritas.com>,
Jan Beulich <jbeulich@novell.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patches] Re: [PATCH] x86-64: adjust pmd_bad()
Date: Wed, 15 Nov 2006 18:23:20 +0100 [thread overview]
Message-ID: <200611151823.20520.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0611151658520.24160@blonde.wat.veritas.com>
On Wednesday 15 November 2006 18:01, Hugh Dickins wrote:
> On Wed, 15 Nov 2006, Jan Beulich wrote:
>
> > Make pmd_bad() symmetrical to pgd_bad() and pud_bad(). At once,
> > simplify them all.
>
> Symmetrical and simpler, yes, but you're weakening the pmd_bad() test:
> no longer requires that all those _KERNPG_TABLE bits be set. Wouldn't
> it be better to go the other way and strengthen pgd_bad, pud_bad?
That's a good point. Yes that would be better. If it works :)
They can't be completely the same because we don't set large page bits on
PGDs (on PUDs we will eventually with 1GB pages)
-Andi
prev parent reply other threads:[~2006-11-15 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 15:06 [PATCH] x86-64: adjust pmd_bad() Jan Beulich
2006-11-15 16:31 ` [patches] " Andi Kleen
2006-11-15 17:01 ` Hugh Dickins
2006-11-15 17:12 ` Jan Beulich
2006-11-15 17:23 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611151823.20520.ak@suse.de \
--to=ak@suse.de \
--cc=hugh@veritas.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.