From: Christoph Hellwig <hch@lst.de>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 5/16] hypervisor functions for Celleb
Date: Wed, 15 Nov 2006 19:37:46 +0100 [thread overview]
Message-ID: <20061115183746.GC21633@lst.de> (raw)
In-Reply-To: <200611150937.kAF9b305001499@toshiba.co.jp>
> +extern int64_t beat_errno;
Please don't use a global arrno variable.
> +static inline int64_t beat_allocate_memory(uint64_t __in0, uint64_t __in1, uint64_t __in2, uint64_t __in3,void** __out0,uint64_t* __out1) {
> + register uint64_t __reg0 __asm__("r3");
> + register uint64_t __reg1 __asm__("r4");
> + register uint64_t __reg2 __asm__("r5");
> + register uint64_t __reg3 __asm__("r6");
> + register uint64_t __sn __asm__("r11") = (0UL);
No point in declaring this a register variable, gcc ignores the
specifier. Is there any chance to not duplicate the inline assembly
for every single hypercall but have generic call with n arguments
helper, as for the phyp hvcalls?
next prev parent reply other threads:[~2006-11-15 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 9:37 [PATCH 5/16] hypervisor functions for Celleb Ishizaki Kou
2006-11-15 18:37 ` Christoph Hellwig [this message]
2006-11-15 22:04 ` Arnd Bergmann
2006-11-16 18:40 ` Jimi Xenidis
2006-11-17 5:21 ` Anton Blanchard
2006-11-18 9:08 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061115183746.GC21633@lst.de \
--to=hch@lst.de \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.