From: Andi Kleen <ak@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch, -rc6] x86_64: UP build fix, arch/x86_64/kernel/mce_amd.c
Date: Thu, 16 Nov 2006 11:29:56 +0100 [thread overview]
Message-ID: <200611161129.56502.ak@suse.de> (raw)
In-Reply-To: <20061116102115.GA8379@elte.hu>
On Thursday 16 November 2006 11:21, Ingo Molnar wrote:
> Subject: [patch] x86_64: UP build fix, arch/x86_64/kernel/mce_amd.c
> From: Ingo Molnar <mingo@elte.hu>
>
> fix x86_64/kernel/mce_amd.c build bug:
>
> arch/x86_64/kernel/mce_amd.c: In function ‘threshold_remove_bank’:
> arch/x86_64/kernel/mce_amd.c:597: error: ‘shared_bank’ undeclared (first use in this function)
> arch/x86_64/kernel/mce_amd.c:597: error: (Each undeclared identifier is reported only once
> arch/x86_64/kernel/mce_amd.c:597: error: for each function it appears in.)
> make[1]: *** [arch/x86_64/kernel/mce_amd.o] Error 1
> make: *** [arch/x86_64/kernel/mce_amd.o] Error 2
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Hmm, it builds for me.
% grep SMP .config
CONFIG_BROKEN_ON_SMP=y
# CONFIG_X86_VSMP is not set
# CONFIG_SMP is not set
% grep MCE_AMD .config
CONFIG_X86_MCE_AMD=y
% ls -l vmlinux
-rwxr-xr-x 1 andi users 9174494 2006-11-16 10:20 vmlinux
(basically just defconfig with CONFIG_SMP disabled)
Perhaps a include ordering problem? Can you send your .config?
-Andi
next prev parent reply other threads:[~2006-11-16 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 10:21 [patch, -rc6] x86_64: UP build fix, arch/x86_64/kernel/mce_amd.c Ingo Molnar
2006-11-16 10:29 ` Andi Kleen [this message]
2006-11-16 11:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611161129.56502.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.