From: Tony Lindgren <tony@atomide.com>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Fix Apollon and OSK ethernet IRQ flags
Date: Fri, 17 Nov 2006 23:46:19 +0200 [thread overview]
Message-ID: <20061117214618.GG6072@atomide.com> (raw)
In-Reply-To: <455C93A5.8010203@gmail.com>
* Dirk Behme <dirk.behme@googlemail.com> [061116 18:46]:
>
> Fix IRQ flags for Apollon and OSK (OMAP5912) board. Apollon
> fix from
> Kyungmin Park (kyungmin.park_at_samsung.com):
>
> Apollon (omap2420) use IRQF_TRIGGER_RISING which means
> IRQF_TRIGGER_HIGH.
>
> Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
>
> Index: linux-osk/drivers/net/smc91x.h
> ===================================================================
> --- linux-osk.orig/drivers/net/smc91x.h
> +++ linux-osk/drivers/net/smc91x.h
> @@ -193,10 +193,12 @@ SMC_outw(u16 val, void __iomem *ioaddr,
> #include <asm/arch/cpu.h>
>
> #ifdef CONFIG_ARCH_OMAP1
> -#define SMC_IRQ_FLAGS (machine_is_omap_innovator() ? IRQF_TRIGGER_RISING : \
> - IRQF_TRIGGER_FALLING)
> +#define SMC_IRQ_FLAGS ((machine_is_omap_innovator() || \
> + machine_is_omap_osk()) \
> + ? IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING)
> #else
> -#define SMC_IRQ_FLAGS IRQF_TRIGGER_LOW
> +#define SMC_IRQ_FLAGS (machine_is_omap_apollon() \
> + ? IRQF_TRIGGER_HIGH : IRQF_TRIGGER_LOW)
> #endif
>
> #elif defined(CONFIG_SH_SH4202_MICRODEV)
Heh, thanks pushing today. Did I manage to break any other boards? :)
Tony
next prev parent reply other threads:[~2006-11-17 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 16:36 [PATCH] ARM: OMAP: Fix Apollon and OSK ethernet IRQ flags Dirk Behme
2006-11-17 21:46 ` Tony Lindgren [this message]
2006-11-18 6:09 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117214618.GG6072@atomide.com \
--to=tony@atomide.com \
--cc=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.