From: Ingo Molnar <mingo@elte.hu>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "'Mike Galbraith'" <efault@gmx.de>, Andrew Morton <akpm@osdl.org>,
nickpiggin@yahoo.com.au, "Siddha,
Suresh B" <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [rfc patch] Re: sched: incorrect argument used in task_hot()
Date: Sat, 18 Nov 2006 08:28:32 +0100 [thread overview]
Message-ID: <20061118072832.GA4234@elte.hu> (raw)
In-Reply-To: <000501c70aa8$01bc4e50$2880030a@amr.corp.intel.com>
* Chen, Kenneth W <kenneth.w.chen@intel.com> wrote:
> - if (sd->nr_balance_failed > sd->cache_nice_tries)
> + if (sd->nr_balance_failed > sd->cache_nice_tries) {
> + #ifdef CONFIG_SCHEDSTATS
> + if (task_hot(p, rq->most_recent_timestamp, sd))
> + schedstat_inc(sd, lb_hot_gained[idle]);
> + #endif
> return 1;
> + }
minor nit: preprocessor directives should be aligned to the first
column.
Ingo
prev parent reply other threads:[~2006-11-18 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 23:00 sched: incorrect argument used in task_hot() Chen, Kenneth W
2006-11-17 16:56 ` [rfc patch] " Mike Galbraith
2006-11-17 19:20 ` Chen, Kenneth W
2006-11-17 19:20 ` Ingo Molnar
2006-11-17 19:41 ` Chen, Kenneth W
2006-11-17 21:30 ` Mike Galbraith
2006-11-17 21:39 ` Andrew Morton
2006-11-17 22:18 ` Mike Galbraith
2006-11-18 0:25 ` Chen, Kenneth W
2006-11-18 7:28 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061118072832.GA4234@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=efault@gmx.de \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.