All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ira Snyder <kernel@irasnyder.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] sparse fix: add lock annotations to nfs client code
Date: Mon, 20 Nov 2006 00:42:07 +0000	[thread overview]
Message-ID: <20061119164207.7b65914a.kernel@irasnyder.com> (raw)

[PATCH] sparse fix: add lock annotations to nfs client code

Fixes 'context imbalance' warnings emitted by sparse while compiling.

Signed-off-by: Ira W. Snyder <kernel@irasnyder.com>

PS - This is my first patch, so I'd like some comments. Questions I have:
1) Should I CC trivial@kernel.org, the LKML itself, or any others?
2) Any problems with the format? I used cg-mkpatch to do it, only edited to add this PS section.

---
commit 59da2d61a2661d99f66085b0d8a7025affbf0a26
tree a25dd0e128fbd8016ac8f9d386064431f3b854cc
parent e030f8294a5b9f8179dae10cdbf9dcf32aa64110
author Ira W. Snyder <kernel@irasnyder.com> Sun, 19 Nov 2006 15:30:38 -0800
committer Ira W. Snyder <kernel@irasnyder.com> Sun, 19 Nov 2006 15:30:38 -0800

 fs/nfs/client.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/client.c b/fs/nfs/client.c
index 5fea638..ae2018b 100644
--- a/fs/nfs/client.c
+++ b/fs/nfs/client.c
@@ -1223,6 +1223,7 @@ static int nfs_server_list_open(struct i
  * set up the iterator to start reading from the server list and return the first item
  */
 static void *nfs_server_list_start(struct seq_file *m, loff_t *_pos)
+__acquires(nfs_client_lock)
 {
 	struct list_head *_p;
 	loff_t pos = *_pos;
@@ -1262,6 +1263,7 @@ static void *nfs_server_list_next(struct
  * clean up after reading from the transports list
  */
 static void nfs_server_list_stop(struct seq_file *p, void *v)
+__releases(nfs_client_lock)
 {
 	spin_unlock(&nfs_client_lock);
 }
@@ -1314,6 +1316,7 @@ static int nfs_volume_list_open(struct i
  * set up the iterator to start reading from the volume list and return the first item
  */
 static void *nfs_volume_list_start(struct seq_file *m, loff_t *_pos)
+__acquires(nfs_client_lock)
 {
 	struct list_head *_p;
 	loff_t pos = *_pos;
@@ -1353,6 +1356,7 @@ static void *nfs_volume_list_next(struct
  * clean up after reading from the transports list
  */
 static void nfs_volume_list_stop(struct seq_file *p, void *v)
+__releases(nfs_client_lock)
 {
 	spin_unlock(&nfs_client_lock);
 }
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2006-11-20  0:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061119164207.7b65914a.kernel@irasnyder.com \
    --to=kernel@irasnyder.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.