From: Stephen Hemminger <shemminger@osdl.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Chris Snook <csnook@redhat.com>,
Jay Cliburn <jacliburn@bellsouth.net>,
jeff@garzik.org, romieu@fr.zoreil.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver
Date: Mon, 20 Nov 2006 10:02:02 -0800 [thread overview]
Message-ID: <20061120100202.6a79e382@freekitty> (raw)
In-Reply-To: <200611201322.00495.arnd@arndb.de>
On Mon, 20 Nov 2006 13:21:59 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday 20 November 2006 07:12, Chris Snook wrote:
> > >
> > > Any reason why you can't use generic_mii_ioctl?
> >
> > I decided to mostly leave this code alone, in the hope that we could
> > just rip out MII support entirely and nobody would mind. What do you think?
> >
>
> Normally, I think you should just implement mdio_read/mdio_write functions
> and then use all the helpers from drivers/net/mii.c to implement mii_ioctl
> and other functions like ethtool_gset.
>
> Arnd <><
>
Using common MII code is good, but one problem with the existing MII code is that
it doesn't work when device is down. This makes it impossible to set speed/duplex
before device comes up.
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-11-20 18:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-19 20:30 [PATCH 3/4] atl1: Main C file for Attansic L1 driver Jay Cliburn
2006-11-19 21:46 ` Jan Engelhardt
2006-11-19 23:57 ` Arnd Bergmann
2006-11-20 6:12 ` Chris Snook
2006-11-20 12:21 ` Arnd Bergmann
2006-11-20 18:02 ` Stephen Hemminger [this message]
2006-11-20 19:35 ` Jeff Garzik
2006-11-20 20:15 ` Stephen Hemminger
2006-11-20 21:36 ` Jeff Garzik
2006-11-20 21:59 ` Stephen Hemminger
2006-11-20 22:04 ` Jeff Garzik
2006-11-20 23:17 ` Stephen Hemminger
2006-11-20 12:39 ` Chris Snook
-- strict thread matches above, loose matches on Subject: below --
2007-01-11 0:42 Jay Cliburn
2007-01-11 9:33 ` Christoph Hellwig
2007-01-21 21:06 Jay Cliburn
2007-01-22 8:22 ` Arjan van de Ven
2007-01-22 16:48 ` Jay Cliburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061120100202.6a79e382@freekitty \
--to=shemminger@osdl.org \
--cc=arnd@arndb.de \
--cc=csnook@redhat.com \
--cc=jacliburn@bellsouth.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.