All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <ml@stefan-roese.de>
To: linux-kernel@vger.kernel.org
Cc: linuxppc-embedded@ozlabs.org
Subject: [PATCH] serial: Use real irq on UART0 (IRQ = 0) on PPC4xx systems
Date: Mon, 20 Nov 2006 12:00:36 +0100	[thread overview]
Message-ID: <200611201200.36780.ml@stefan-roese.de> (raw)

This patch fixes a problem seen on multiple 4xx platforms, where
the UART0 interrupt number is 0. The macro "is_real_interrupt" lead
on those systems to not use an real interrupt but the timer based
implementation.

This problem was detected and fixed by
Charles Gales <cgales@amcc.com> and John Baxter <jbaxter@amcc.com>
from AMCC.

Signed-off-by: Stefan Roese <sr@denx.de>

---
commit f83094acd3258575c9a5cdb1d65e241c16eff03a
tree 72582c5eeb2a9c8ea57287616d51e42fff8ed641
parent f56f68c4e1977f0e884a304af4c617bed4909417
author Stefan Roese <sr@denx.de> Sat, 18 Nov 2006 10:28:50 +0100
committer Stefan Roese <sr@denx.de> Sat, 18 Nov 2006 10:28:50 +0100

 drivers/serial/8250.c |   22 ++++++++++++++--------
 1 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index e34bd03..a51679e 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -76,8 +76,14 @@ static unsigned int nr_uarts = CONFIG_SE
  * We default to IRQ0 for the "no irq" hack.   Some
  * machine types want others as well - they're free
  * to redefine this in their header file.
+ * NOTE:  Some PPC4xx use IRQ0 for a UART Interrupt, so
+ * we will assume that the IRQ is always real
  */
+#ifdef CONFIG_4xx
+#define is_real_interrupt(irq)	(1)
+#else
 #define is_real_interrupt(irq)	((irq) != 0)
+#endif

 #ifdef CONFIG_SERIAL_8250_DETECT_IRQ
 #define CONFIG_SERIAL_DETECT_IRQ 1

             reply	other threads:[~2006-11-20 11:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20 11:00 Stefan Roese [this message]
2006-11-20 11:24 ` [PATCH] serial: Use real irq on UART0 (IRQ = 0) on PPC4xx systems Peter Korsgaard
2006-11-20 11:42 ` Alan
2006-11-20 11:54   ` Stefan Roese
2006-11-20 12:10     ` Alan
2006-11-20 13:04       ` Russell King
2006-11-20 13:04         ` Russell King
2006-11-20 21:21         ` Guennadi Liakhovetski
2006-11-20 21:21           ` Guennadi Liakhovetski
2006-11-20 13:28 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611201200.36780.ml@stefan-roese.de \
    --to=ml@stefan-roese.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.