From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: Trivial patch to fix logging level output by XendCheckpoint.py Date: Mon, 20 Nov 2006 22:43:23 +0000 Message-ID: <20061120224323.GF15703@redhat.com> References: <342BAC0A5467384983B586A6B0B3767104190365@EXNA.corp.stratus.com> <20061120215600.GE15703@redhat.com> <45622D6E.9020607@us.ibm.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <45622D6E.9020607@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: xen-devel , Christian Limpach List-Id: xen-devel@lists.xenproject.org On Mon, Nov 20, 2006 at 04:34:22PM -0600, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >On Mon, Nov 20, 2006 at 04:34:25PM -0500, Graham, Simon wrote: > >>Signed-off by: Simon Graham > > >And even more importantly, once we get the error reporting patches > >integrated > >into libxc, having the xc_linux_save/restore calls made by XenD directly > >would ensure we get reliable error handling for save/restore operations. > > It used to work that way. xc_linux_save/restore were factored out of > Xend late in the 3.0 dev process. I believe the idea was that they > should be executed with lower privileges (which is why they take file > descriptors as command line arguments instead of just calling > xc_interface_open() like you would expect). > > I believe it was Christian who was driving this. Perhaps he has a few > more details? Ok, looking back at the HG logs it appears # 5099 "Execute xc_linux_restore in a seperate process so that it can't crash xend. Also handle errors passed from xc_linux_restore and log info messages from xc_linux_restore." and # 5121: "Implement the parts of vm save which need interaction with xend as part of xend, instead of using xfrd. Execute xc_linux_save in a seperate process so that it can't crash xend. Also handle errors passed from xc_linux_save. are where these programs came into existance. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|