From: Ira Snyder <kernel@irasnyder.com>
To: netdev@vger.kernel.org
Cc: mchan@broadcom.com
Subject: [PATCH] tg3: add missing unlock in tg3_open() error path
Date: Tue, 21 Nov 2006 14:23:11 -0800 [thread overview]
Message-ID: <20061121142311.4d1b9510.kernel@irasnyder.com> (raw)
[PATCH] tg3: add missing unlock in tg3_open() error path
Sparse noticed a locking imbalance in tg3_open(). This patch adds an unlock
to one of the error paths, so that tg3_open() always exits without the
lock held.
Signed-off-by: Ira W. Snyder <kernel@irasnyder.com>
---
commit e114d89ecaab99bc175c1db497d9c851e750ca3d
tree d4e82d18cd108d9dea4d01b81890d86c0519048d
parent f84c313680a21fd6c487ac17f69c4c115472e257
author Ira W. Snyder <kernel@irasnyder.com> Mon, 20 Nov 2006 11:03:03 -0800
committer Ira W. Snyder <kernel@irasnyder.com> Mon, 20 Nov 2006 11:03:03 -0800
drivers/net/tg3.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 1dbdd6b..c20bb99 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -6979,8 +6979,10 @@ static int tg3_open(struct net_device *d
tg3_full_lock(tp, 0);
err = tg3_set_power_state(tp, PCI_D0);
- if (err)
+ if (err) {
+ tg3_full_unlock(tp);
return err;
+ }
tg3_disable_ints(tp);
tp->tg3_flags &= ~TG3_FLAG_INIT_COMPLETE;
next reply other threads:[~2006-11-21 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 22:23 Ira Snyder [this message]
2006-11-22 1:44 ` [PATCH] tg3: add missing unlock in tg3_open() error path David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061121142311.4d1b9510.kernel@irasnyder.com \
--to=kernel@irasnyder.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.