From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: Re: [PATCH] add check for python-devel to tools build
Date: Tue, 21 Nov 2006 17:10:43 +0000
Message-ID: <20061121171043.GH1951@redhat.com>
References: <45633B55.76E4.0078.0@novell.com> <45632EA5.6090404@us.ibm.com>
	<20061121170649.GH30929@leeni.uk.xensource.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20061121170649.GH30929@leeni.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ewan Mellor <ewan@xensource.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, xen-devel <xen-devel@lists.xensource.com>, Jan Beulich <jbeulich@novell.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Nov 21, 2006 at 05:06:49PM +0000, Ewan Mellor wrote:
> On Tue, Nov 21, 2006 at 10:51:49AM -0600, Anthony Liguori wrote:
> 
> > Jan Beulich wrote:
> > >Again, this must be given exec permission after applying.
> > >
> > >Signed-off-by: Jan Beulich <jbeulich@novell.com>
> > >
> > >Index: 2006-11-17/tools/check/check_python_devel
> > >===================================================================
> > >--- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > >+++ 2006-11-17/tools/check/check_python_devel	2006-11-21 
> > >12:03:08.000000000 +0100
> > >@@ -0,0 +1,13 @@
> > >+#!/bin/bash
> > >+# CHECK-BUILD
> > >+
> > >+function error {
> > >+    echo
> > >+    echo "  *** Check for python development environment FAILED"
> > >+    exit 1
> > >+}
> > >+
> > >+lib=lib
> > >+test "$(uname -m)" != x86_64 || lib=lib64
> > >+set -e
> > >+[ -e /usr/$lib/python/config/Makefile ] || error
> > 
> > There is no /usr/lib/python/config/Makefile on Ubuntu.  You should be 
> > okay if you also check for /usr/lib/python-2.[345]/config/Makefile.
> 
> My Debian box has /usr/lib/python2.3.  How about
> /usr/lib/python*/config/Makefile?  That should be OK, and has the advantage of
> including /usr/lib/python.

Using wildcards though will not be reliable. eg I have both python 2.3 and 2.4
installed, but python 2.4 is the version I'm deploying Xen against. This test
won't catch the case where I have  python-devel = 2.3, but don't have the
python-devel == 2.4 installed. We want to make sure we only check against the
version we're actually building against. 

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|