From: Alan <alan@lxorguk.ukuu.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andi Kleen <ak@suse.de>, Adrian Bunk <bunk@stusta.de>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [2.6.19 patch] i386/x86_64: remove the unused EXPORT_SYMBOL(dump_trace)
Date: Tue, 21 Nov 2006 21:06:22 +0000 [thread overview]
Message-ID: <20061121210622.6cea428f@localhost.localdomain> (raw)
In-Reply-To: <20061121201844.GA7099@infradead.org>
On Tue, 21 Nov 2006 20:18:44 +0000
Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Nov 21, 2006 at 08:47:30PM +0100, Andi Kleen wrote:
> > On Tuesday 21 November 2006 20:41, Adrian Bunk wrote:
> > > This patch removes the unused EXPORT_SYMBOL(dump_trace) added on i386
> > > and x86_64 in 2.6.19-rc.
> > >
> > > By removing them before the final 2.6.19 we avoid the possibility of
> > > people later whining that we removed exports they started using.
> >
> > I exported it for systemtap so that they can stop using the broken
> > hack they currently use as unwinder.
>
> Nack, dump_trace is nothing that should be export for broken out of tree
> junk.
It is exported for systemtap not random broken out of tree junk, and the
result is a good deal prettier. Systemtap guys really ought to get their
stuff merged too, although how we merge a dynamic module writing tool I'm
not so sure ?
Alan
next prev parent reply other threads:[~2006-11-21 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 19:41 [2.6.19 patch] i386/x86_64: remove the unused EXPORT_SYMBOL(dump_trace) Adrian Bunk
2006-11-21 19:47 ` Andi Kleen
2006-11-21 20:18 ` Christoph Hellwig
2006-11-21 21:06 ` Alan [this message]
2006-11-22 7:40 ` Vara Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061121210622.6cea428f@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=discuss@x86-64.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.