From: David Chinner <dgc@sgi.com>
To: xfs-dev@sgi.com
Cc: xfs@oss.sgi.com
Subject: Review: Fix inverted quiet mount logic
Date: Wed, 22 Nov 2006 15:46:56 +1100 [thread overview]
Message-ID: <20061122044656.GS37654165@melbourne.sgi.com> (raw)
Simple problem Noticed by Eric Sandeen at about the same time I did
- we are not getting error messages in dmesg when certain checks
fail during mount. Turns out the XFS_MFSI_QUIET flag usage is
inverted, so we suppress messages when we should be noisy and
shout when we should be silent....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
---
fs/xfs/xfs_error.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6.x-xfs-new/fs/xfs/xfs_error.h
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/xfs_error.h 2006-10-17 12:17:25.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/xfs_error.h 2006-11-16 09:45:03.444451972 +1100
@@ -180,6 +180,6 @@ extern void xfs_fs_cmn_err(int level, st
xfs_fs_cmn_err(level, mp, fmt " Unmount and run xfs_repair.", ## args)
#define xfs_fs_mount_cmn_err(f, fmt, args...) \
- ((f & XFS_MFSI_QUIET)? cmn_err(CE_WARN, "XFS: " fmt, ## args) : (void)0)
+ ((f & XFS_MFSI_QUIET)? (void)0 : cmn_err(CE_WARN, "XFS: " fmt, ## args))
#endif /* __XFS_ERROR_H__ */
next reply other threads:[~2006-11-22 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 4:46 David Chinner [this message]
2006-11-22 4:51 ` Review: Fix inverted quiet mount logic Timothy Shimmin
2006-11-22 5:02 ` David Chatterton
2006-11-22 5:15 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061122044656.GS37654165@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.