From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: Re: [PATCH] make ballooning up to maxmem work
Date: Wed, 22 Nov 2006 08:40:22 -0200
Message-ID: <20061122104021.GA2496@redhat.com>
References: <456368E5.70906@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <456368E5.70906@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Rik van Riel <riel@redhat.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

  
>      case XENMEM_current_reservation:
>      case XENMEM_maximum_reservation:
> +    case XENMEM_maximum_memory:
>          if ( copy_from_guest(&domid, arg, 1) )
>              return -EFAULT;

This still makes use of d->max_pages in return. Isn't it supposed to
change in the future too? IIRC, according to Keir, max_pages will track 
the _current_ number of pages, differing from tot_pages only in a brief
timeframe in which you balloon, but tot_pages was not yet updated.


-- 
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"