From: Jens Osterkamp <jens@de.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: Jens Osterkamp <jens.osterkamp@de.ibm.com>,
Benjamin Herrenschmidt <benh@au1.ibm.com>,
Paul Mackerras <paulus@samba.org>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] powerpc: Fix __raw* accessors
Date: Wed, 22 Nov 2006 14:46:02 +0100 [thread overview]
Message-ID: <200611221446.02716.jens@de.ibm.com> (raw)
In-Reply-To: <200611211129.59685.arnd@arndb.de>
On Tuesday 21 November 2006 11:29, Arnd Bergmann wrote:
> On Tuesday 21 November 2006 02:35, Benjamin Herrenschmidt wrote:
> > The new IO accessor code allows to stick a token in the top bit of MMIO
> > addresses which gets masked out during actual accesses. However, the
> > __raw_* accessors forgot to mask it out. This fixes it.
>
> Jens, you debugged the problem originally. Does this patch fix it entirely,
> or is there something else missing?
The driver basically works, but I am seeing strange im_free messages,
probably because this code is not aware of the tokens in the ioremapped
addresses.
<6>ib_mthca: Mellanox InfiniBand HCA driver v0.08 (February 14, 2006)
<6>ib_mthca: Initializing 0002:00:00.0
<3>Trying to im_free nonexistent area (d002080080930000)
<6>ib_mthca: Initializing 0004:00:00.0
<3>Trying to im_free nonexistent area (d003080082a37000)
<4>ib_mthca 0004:00:00.0: HCA FW version 4.6.0 is old (4.7.600 is current).
<4>ib_mthca 0004:00:00.0: If you have problems, try updating your HCA FW.
Jens
next prev parent reply other threads:[~2006-11-22 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 1:35 [PATCH] powerpc: Fix __raw* accessors Benjamin Herrenschmidt
2006-11-21 10:29 ` Arnd Bergmann
2006-11-22 13:46 ` Jens Osterkamp [this message]
2006-11-22 21:18 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611221446.02716.jens@de.ibm.com \
--to=jens@de.ibm.com \
--cc=arnd@arndb.de \
--cc=benh@au1.ibm.com \
--cc=jens.osterkamp@de.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.