From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: David Brownell <david-b@pacbell.net>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [patch 2.6.19-rc6 6/6] rtc-omap driver
Date: Wed, 22 Nov 2006 21:34:14 +0100 [thread overview]
Message-ID: <20061122213414.5199f5c0@inspiron> (raw)
In-Reply-To: <200611211815.43929.david-b@pacbell.net>
On Tue, 21 Nov 2006 18:15:42 -0800
David Brownell <david-b@pacbell.net> wrote:
> On Tuesday 21 November 2006 5:19 pm, Andrew Morton wrote:
> > On Mon, 20 Nov 2006 10:28:48 -0800
>
> > > + /* sometimes the alarm wraps into tomorrow */
> > > + if (then < now) {
> >
> > This isn't wraparound-safe. If you have then=0xffffffff and now=0x00000001.
> >
> > Perhaps that can't happen.
>
> Starting in 2037 or whenever, various things will be breaking...
>
> Probably the RTC lib routines should use a time_t, and when that gets
> changed to 64 bits then things like this will be fixed automagically.
> Right now they use "unsigned long".
>
> I suggest Alessandro handle those issues.
I'll make a note for switching to time_t before
2037 :)
--
Best regards,
Alessandro Zummo,
Tower Technologies - Turin, Italy
http://www.towertech.it
prev parent reply other threads:[~2006-11-22 20:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 18:14 [patch 2.6.19-rc6 0/6] more rtc framework/driver updates David Brownell
2006-11-20 18:17 ` [patch 2.6.19-rc6 1/6] rtc class /proc/driver/rtc update David Brownell
2006-11-20 23:13 ` Alessandro Zummo
2006-11-21 2:47 ` [Bulk] " David Brownell
2006-11-22 20:37 ` Alessandro Zummo
2006-11-23 0:39 ` David Brownell
2006-11-20 18:19 ` [patch 2.6.19-rc6 2/6] rtc-sa1100 tweaks David Brownell
2006-11-20 22:48 ` Russell King
2006-11-21 1:46 ` David Brownell
2006-11-20 18:22 ` [patch 2.6.19-rc6 3/6] X86_PC optionally creates rtc_cmos platform device David Brownell
2006-11-20 18:27 ` [patch 2.6.19-rc6 5/6] rtc-cmos driver David Brownell
2006-11-20 18:27 ` [patch 2.6.19-rc6 4/6] ACPI exports RTC extensions through platform_data David Brownell
2006-11-20 18:28 ` [patch 2.6.19-rc6 6/6] rtc-omap driver David Brownell
2006-11-20 23:09 ` Alessandro Zummo
2006-11-22 1:19 ` Andrew Morton
2006-11-22 2:15 ` David Brownell
2006-11-22 2:28 ` Andrew Morton
2006-11-23 0:09 ` David Brownell
2006-11-22 20:34 ` Alessandro Zummo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061122213414.5199f5c0@inspiron \
--to=alessandro.zummo@towertech.it \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.