All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: drzeus-mmc@drzeus.cx, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix random SD/MMC card recognition failures on ARM Versatile
Date: Thu, 23 Nov 2006 16:03:35 +0000	[thread overview]
Message-ID: <20061123160335.GB8984@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20061123184606.bb203ae6.vitalywool@gmail.com>

On Thu, Nov 23, 2006 at 06:46:06PM +0300, Vitaly Wool wrote:
> Hello Pierre,
> 
> currently sometimes the SD/MMC card inserted results in recognition failure on ARM Versatile board:
> 
>    <<<Plug in MMC card>>>
> 
> root@versatile:~# mmcblk0: mmc0:0001 SDMB-32 31360KiB
>  mmcblk0:<3>mmcblk0: error 3 transferring data
> end_request: I/O error, dev mmcblk0, sector 0
> Buffer I/O error on device mmcblk0, logical block 0
> mmcblk0: error 3 transferring data
> end_request: I/O error, dev mmcblk0, sector 0
> Buffer I/O error on device mmcblk0, logical block 0
>  unable to read partition table
> 
> This patch fixes the problem.

Doubtful.  mmci_stop_data() already does this, which will be called
immediately prior to mmci_request_end().  So you're doubling up the
writes to registers again.

Since this is not the first occurance that you've had to do this with
your board (the other being the SIC) I suggest that your board is
faulty in some way, causing writes to registers to be occasionally
dropped.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2006-11-23 16:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-23 15:46 [PATCH] fix random SD/MMC card recognition failures on ARM Versatile Vitaly Wool
2006-11-23 16:03 ` Russell King [this message]
2006-11-23 19:29   ` Vitaly Wool
2006-11-23 19:42     ` Russell King
2006-11-23 19:57       ` Russell King
2006-11-24  7:54       ` Vitaly Wool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061123160335.GB8984@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vitalywool@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.