From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 6/6]: Tidy up unused structures
Date: Fri, 24 Nov 2006 10:05:34 +0000 [thread overview]
Message-ID: <200611241005.34519@strip-the-willow> (raw)
In-Reply-To: <200611211545.46843@strip-the-willow>
Quoting Arnaldo Carvalho de Melo:
| > --- a/net/dccp/proto.c
| > +++ b/net/dccp/proto.c
| > @@ -469,9 +469,6 @@ static int do_dccp_setsockopt(struct soc
| >
| > lock_sock(sk);
| > switch (optname) {
| > - case DCCP_SOCKOPT_PACKET_SIZE:
| > - dp->dccps_packet_size = val;
| > - break;
|
| ... printk(KERN_WARNING "setsockopt(PACKET_SIZE) is deprecated, "
| "fix your app\n");
Many thanks for spotting this - I will update the patch and resubmit it.
How bad to think what happens if 1 gets re-allocated and an old app tries
to set it ... :-x
Gerrit
prev parent reply other threads:[~2006-11-24 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 15:45 [PATCH 6/6]: Tidy up unused structures Gerrit Renker
2006-11-23 23:30 ` Arnaldo Carvalho de Melo
2006-11-24 10:05 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611241005.34519@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.