From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Juergen Ruehle <j.ruehle@bmiag.de>, git@vger.kernel.org
Subject: Re: filemode=false somewhat broken
Date: Sat, 25 Nov 2006 01:10:34 -0500 [thread overview]
Message-ID: <20061125061034.GA4528@spearce.org> (raw)
In-Reply-To: <7vodqzp0mh.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> Juergen Ruehle <j.ruehle@bmiag.de> writes:
>
> > Commit fd28b34afd9bbd58297a25edced3f504c9a5487a tried to ignore the
> > executable bit if filemode=false, but instead forced all files to be
> > regular with 644 permission bits nuking symlink support.
>
> Thanks for noticing. Yes, that change is _seriously_ broken. I
> should really raise the bar for patch acceptance.
Whoops.
I don't work with symlinks so I never noticed the breakage myself.
Clearly the test cases that I created in fd28b3 should also have
included symlinks, but they did not... and we see this breakage
occur.
--
prev parent reply other threads:[~2006-11-25 6:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 20:02 filemode=false somewhat broken Juergen Ruehle
2006-11-22 22:39 ` Junio C Hamano
2006-11-25 6:10 ` Shawn Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061125061034.GA4528@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=j.ruehle@bmiag.de \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.