From: Adrian Bunk <bunk@stusta.de>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [2.6 patch] make hdlc_setup() static again
Date: Sat, 25 Nov 2006 20:16:53 +0100 [thread overview]
Message-ID: <20061125191653.GJ3702@stusta.de> (raw)
In-Reply-To: <m3veqnlnsh.fsf@defiant.localdomain>
On Mon, Jun 26, 2006 at 09:28:14PM +0200, Krzysztof Halasa wrote:
> Adrian Bunk <bunk@stusta.de> writes:
>
> > hdlc_setup() is now EXPORTed as per David's request.
> >
> > Is a usage of this export pending for the near future
>
> I'm told it is.
It's still not used...
So let's unexport it again until some driver that actually uses it shows up.
> Krzysztof Halasa
cu
Adrian
<-- snip -->
hdlc_setup was exported, but this export was never used.
If adriver using it actually shows up it can still be exported again.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c.old 2006-11-25 00:16:13.000000000 +0100
+++ linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c 2006-11-25 00:16:26.000000000 +0100
@@ -222,7 +222,7 @@
return -EINVAL;
}
-void hdlc_setup(struct net_device *dev)
+static void hdlc_setup(struct net_device *dev)
{
hdlc_device *hdlc = dev_to_hdlc(dev);
@@ -325,7 +325,6 @@
EXPORT_SYMBOL(hdlc_open);
EXPORT_SYMBOL(hdlc_close);
EXPORT_SYMBOL(hdlc_ioctl);
-EXPORT_SYMBOL(hdlc_setup);
EXPORT_SYMBOL(alloc_hdlcdev);
EXPORT_SYMBOL(unregister_hdlc_device);
EXPORT_SYMBOL(register_hdlc_protocol);
next prev parent reply other threads:[~2006-11-25 19:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 20:51 -git: Why is drivers/net/wan/hdlc_generic.c:hdlc_setup() exported? Adrian Bunk
2006-06-26 19:28 ` Krzysztof Halasa
2006-11-25 19:16 ` Adrian Bunk [this message]
2006-11-26 19:22 ` [2.6 patch] make hdlc_setup() static again Krzysztof Halasa
-- strict thread matches above, loose matches on Subject: below --
2007-01-11 13:48 Adrian Bunk
2007-01-19 3:01 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061125191653.GJ3702@stusta.de \
--to=bunk@stusta.de \
--cc=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.