From: Christoph Hellwig <hch@infradead.org>
To: Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
James Morris <jmorris@namei.org>,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH] selinux: fix dentry_open() error check
Date: Mon, 27 Nov 2006 06:35:58 +0000 [thread overview]
Message-ID: <20061127063558.GA6688@infradead.org> (raw)
In-Reply-To: <20061127061648.GA20065@APFDCB5C>
On Mon, Nov 27, 2006 at 03:16:48PM +0900, Akinobu Mita wrote:
> The return value of dentry_open() shoud be checked by IS_ERR().
first great work finding all these calling convetion mismatches.
Do you have some tool to find these?
I wonder whether we should have some form of sparse annotation to
tell that a function returns these kinds of errors and we either
need to check IS_ERR or returned it again a caller with the same attribute.
next prev parent reply other threads:[~2006-11-27 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 6:16 [PATCH] selinux: fix dentry_open() error check Akinobu Mita
2006-11-27 6:35 ` Christoph Hellwig [this message]
2006-11-27 6:58 ` Akinobu Mita
2006-11-27 15:29 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127063558.GA6688@infradead.org \
--to=hch@infradead.org \
--cc=akinobu.mita@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.