From: Andi Kleen <ak@suse.de>
To: Olivier Galibert <galibert@pobox.com>, Andi Kleen <ak@suse.de>,
linux-pci@atrey.karlin.mff.cuni.cz,
"Hack inc." <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] PCI MMConfig: Detect and support the E7520 and the 945G/GZ/P/PL
Date: Mon, 27 Nov 2006 20:07:48 +0100 [thread overview]
Message-ID: <20061127190748.GA7015@bingen.suse.de> (raw)
In-Reply-To: <20061127190301.GA75765@dspnet.fr.eu.org>
On Mon, Nov 27, 2006 at 08:03:01PM +0100, Olivier Galibert wrote:
> On Sun, Nov 26, 2006 at 08:28:04PM +0100, Andi Kleen wrote:
> > On Sunday 26 November 2006 14:15, Olivier Galibert wrote:
> > > Ok, here you go, what about that? I'll be able to test it on i386 on
> > > monday, not before. It's hard to doa full 32bits install remotely :-)
> >
> > Sorry, please don't put it all into a single patch. Do one patch
> > that just moves code, then add new functionality later.
> > Otherwise nobody can review it properly.
>
> Ok, I have it split in 5 parts, but the testing on i386 failed simply
> because the vanilla code there just does not work. Symptom is the
> SATA driver not seeing the disk somehow.
Weird. That shouldn't happen.
Is that with just the code movement patch or your feature patch
added too? If the later can you test it with only code movement
(and compare against vanilla kernel). at least code movement
only should behave exactly the same as unpatched kernel.
-Andi
next prev parent reply other threads:[~2006-11-27 19:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 19:51 [PATCH] PCI MMConfig: Detect and support the E7520 and the 945G/GZ/P/PL Olivier Galibert
2006-11-23 19:57 ` Arjan van de Ven
2006-11-23 20:40 ` Matthew Wilcox
2006-11-23 20:44 ` Olivier Galibert
2006-11-25 19:34 ` Andi Kleen
2006-11-25 20:51 ` Olivier Galibert
2006-11-25 20:59 ` Andi Kleen
2006-11-26 13:15 ` Olivier Galibert
2006-11-26 19:28 ` Andi Kleen
2006-11-27 19:03 ` Olivier Galibert
2006-11-27 19:07 ` Andi Kleen [this message]
2006-11-27 20:24 ` Olivier Galibert
2006-12-01 0:19 ` Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127190748.GA7015@bingen.suse.de \
--to=ak@suse.de \
--cc=galibert@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.