From: Martin Waitz <tali@admingilde.org>
To: git@vger.kernel.org
Subject: SEGV when lookup_* returns NULL
Date: Mon, 27 Nov 2006 22:13:15 +0100 [thread overview]
Message-ID: <20061127211315.GC18810@admingilde.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
hoi :)
When trying to an unmodified GIT on a repository with submodules
it segfaults a lot.
All the lookup_{blob,tree,commit} functions check that the object
really is of the requested type and return NULL otherwise.
However this NULL pointer is not checked in the calling functions.
Should we make lookup_* to just die when invoked on another object-type?
Or modify all the callers?
Is there a sane error-handling strategy besides dying in this case?
Really checking all the return values in the whole chain would be
a lot of work.
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2006-11-27 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 21:13 Martin Waitz [this message]
2006-11-27 21:55 ` SEGV when lookup_* returns NULL Junio C Hamano
2006-11-27 23:33 ` Johannes Schindelin
2006-11-28 0:13 ` Junio C Hamano
2006-11-28 2:23 ` Morten Welinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127211315.GC18810@admingilde.org \
--to=tali@admingilde.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.