All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: geert@linux-m68k.org, zippel@linux-m68k.org, gregkh@suse.de,
	David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
	linux-pci@atrey.karlin.mff.cuni.cz
Subject: [RFC: 2.6 patch] don't export device IDs to userspace
Date: Tue, 28 Nov 2006 02:28:34 +0100	[thread overview]
Message-ID: <20061128012834.GT15364@stusta.de> (raw)

I don't see any good reason for exporting device IDs to userspace.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 include/linux/Kbuild |    2 --
 include/linux/pci.h  |    6 +++---
 2 files changed, 3 insertions(+), 5 deletions(-)

--- linux-2.6.19-rc6-mm1/include/linux/Kbuild.old	2006-11-27 22:19:55.000000000 +0100
+++ linux-2.6.19-rc6-mm1/include/linux/Kbuild	2006-11-27 22:24:53.000000000 +0100
@@ -122,7 +122,6 @@
 header-y += nfs_mount.h
 header-y += oom.h
 header-y += param.h
-header-y += pci_ids.h
 header-y += pci_regs.h
 header-y += personality.h
 header-y += pfkeyv2.h
@@ -165,7 +164,6 @@
 header-y += wireless.h
 header-y += xattr.h
 header-y += x25.h
-header-y += zorro_ids.h
 
 unifdef-y += acct.h
 unifdef-y += adb.h
--- linux-2.6.19-rc6-mm1/include/linux/pci.h.old	2006-11-27 23:11:11.000000000 +0100
+++ linux-2.6.19-rc6-mm1/include/linux/pci.h	2006-11-27 23:11:47.000000000 +0100
@@ -20,9 +20,6 @@
 /* Include the pci register defines */
 #include <linux/pci_regs.h>
 
-/* Include the ID list */
-#include <linux/pci_ids.h>
-
 /*
  * The PCI interface treats multi-function devices as independent
  * devices.  The slot/function address of each device is encoded
@@ -53,6 +50,9 @@
 #include <linux/errno.h>
 #include <linux/device.h>
 
+/* Include the ID list */
+#include <linux/pci_ids.h>
+
 /* File state for mmap()s on /proc/bus/pci/X/Y */
 enum pci_mmap_state {
 	pci_mmap_io,


             reply	other threads:[~2006-11-28  1:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28  1:28 Adrian Bunk [this message]
2006-12-01  7:05 ` [RFC: 2.6 patch] don't export device IDs to userspace Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061128012834.GT15364@stusta.de \
    --to=bunk@stusta.de \
    --cc=dwmw2@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.