All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
	Andi Kleen <ak@suse.de>
Subject: [patch] x86_64: fix earlyprintk=...,keep regression
Date: Tue, 28 Nov 2006 09:14:05 +0100	[thread overview]
Message-ID: <20061128081405.GA9031@elte.hu> (raw)

Subject: [patch] x86_64: fix earlyprintk=...,keep regression
From: Ingo Molnar <mingo@elte.hu>

the following cleanup patch:

 commit 2c8c0e6b8d7700a990da8d24eff767f9ca223b96
 Author: Andi Kleen <ak@suse.de>
 Date:   Tue Sep 26 10:52:32 2006 +0200

     [PATCH] Convert x86-64 to early param

     Instead of hackish manual parsing

broke the earlyprintk=...,keep feature. This patch restores that 
functionality. Tested on x86_64. Must-have for v2.6.19, no risk.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86_64/kernel/early_printk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/arch/x86_64/kernel/early_printk.c
===================================================================
--- linux.orig/arch/x86_64/kernel/early_printk.c
+++ linux/arch/x86_64/kernel/early_printk.c
@@ -224,7 +224,7 @@ static int __init setup_early_printk(cha
 		return 0;
 	early_console_initialized = 1;
 
-	if (!strcmp(buf,"keep"))
+	if (strstr(buf, "keep"))
 		keep_early = 1;
 
 	if (!strncmp(buf, "serial", 6)) {

             reply	other threads:[~2006-11-28  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28  8:14 Ingo Molnar [this message]
2006-11-28 18:52 ` [patch] x86_64: fix earlyprintk=...,keep regression Linus Torvalds
2006-11-28 18:56   ` Linus Torvalds
2006-11-28 18:57   ` Andi Kleen
2006-11-28 19:56   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061128081405.GA9031@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.