All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: [RFC] [PATCH 1/2]: Remove small typo
Date: Tue, 28 Nov 2006 14:34:31 +0000	[thread overview]
Message-ID: <200611281434.31175@strip-the-willow> (raw)

[CCID 3]: Remove small typo

This removes a small typo introduced by an earlier patch.

===> It is sent as RFC since it would be a much better idea to
       revise this so that the nofeedback timer expires after 
             max(4*R, 2 * s/X) 
       instead of after 
        max(t_rto, 2 * s/X)  =  max(max(4*R, 1 second), 2 *s/X)
       as is currently the case.

===> Advantage:
           * the current solution is non-standard
           * simulation experience suggest that  max(4*R, 2 * s/X)
             is better, especially if R is small

===>  OK with this suggestion?


Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
 net/dccp/ccids/ccid3.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -246,7 +246,7 @@ static void ccid3_hc_tx_no_feedback_time
 		}
 		/*
 		 * Schedule no feedback timer to expire in
-		 * max(4 * t_RTO, 2 * s/X)  =  max(4 * t_RTO, 2 * t_ipi)
+		 * max(t_RTO, 2 * s/X)  =  max(t_RTO, 2 * t_ipi)
 		 * XXX This is non-standard, RFC 3448, 4.3 uses 4 * R
 		 */
 		next_tmout = max(hctx->ccid3hctx_t_rto, 2*hctx->ccid3hctx_t_ipi);
@@ -523,7 +523,7 @@ static void ccid3_hc_tx_packet_recv(stru
 					      	   USEC_PER_SEC            );
 		/*
 		 * Schedule no feedback timer to expire in
-		 * max(4 * t_RTO, 2 * s/X)  =  max(4 * t_RTO, 2 * t_ipi)
+		 * max(t_RTO, 2 * s/X)  =  max(t_RTO, 2 * t_ipi)
 		 * XXX This is non-standard, RFC 3448, 4.3 uses 4 * R
 		 */
 		next_tmout = max(hctx->ccid3hctx_t_rto, 2*hctx->ccid3hctx_t_ipi);

             reply	other threads:[~2006-11-28 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28 14:34 Gerrit Renker [this message]
2006-11-28 19:26 ` [RFC] [PATCH 1/2]: Remove small typo Ian McDonald
2006-11-28 20:21 ` Arnaldo Carvalho de Melo
2006-11-28 20:25 ` Gerrit Renker
2006-11-28 20:27 ` Ian McDonald
2006-11-28 20:28 ` Arnaldo Carvalho de Melo
2006-11-28 20:35 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611281434.31175@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.