From: Arnaldo Carvalho de Melo <acme@mandriva.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 2/2]: Use `unsigned' for packet lengths
Date: Tue, 28 Nov 2006 20:27:24 +0000 [thread overview]
Message-ID: <20061128202723.GF19882@mandriva.com> (raw)
In-Reply-To: <200611281435.05466@strip-the-willow>
On Wed, Nov 29, 2006 at 09:17:04AM +1300, Ian McDonald wrote:
> On 11/29/06, Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
> >Quoting Ian McDonald:
> >| I think I didn't explain my point well here. You can't change to u32
> >| but need to be unsigned int (not u64).
> >Don't get this: u32 is a 32-bit unsigned value and therefore looks
> >sufficient - and you
> >are proposing `unsigned int' to have easier conversion to skb->len, right?
> >
> OK. On 64 bit platform unsigned int = 64 bits and we are passing a 64
> bit argument (skb->len) into a 32 bit parameter. We either need to
> explicitly typecast or change wherever you have put u32 to unsigned
> int.
>
> Arnaldo probably knows which way is better from his experience.
Just make it unsigned int, matching skb->len
- Arnaldo
next prev parent reply other threads:[~2006-11-28 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 14:35 [PATCH 2/2]: Use `unsigned' for packet lengths Gerrit Renker
2006-11-28 19:34 ` Ian McDonald
2006-11-28 19:41 ` Gerrit Renker
2006-11-28 19:49 ` Ian McDonald
2006-11-28 20:04 ` Gerrit Renker
2006-11-28 20:17 ` Ian McDonald
2006-11-28 20:27 ` Arnaldo Carvalho de Melo [this message]
2006-11-28 20:31 ` Gerrit Renker
2006-11-28 20:37 ` Arnaldo Carvalho de Melo
2006-11-28 20:53 ` Gerrit Renker
2006-11-28 21:01 ` Ian McDonald
2006-11-28 21:19 ` Eddie Kohler
2006-11-28 21:56 ` Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128202723.GF19882@mandriva.com \
--to=acme@mandriva.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.