From: Christoph Hellwig <hch@infradead.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
aia21@cantab.net
Subject: Re: [PATCH 1/2] lib + ntfs: let modules force HWEIGHT
Date: Wed, 29 Nov 2006 08:40:09 +0000 [thread overview]
Message-ID: <20061129084009.GC12734@infradead.org> (raw)
In-Reply-To: <20061128140840.f87540e8.randy.dunlap@oracle.com>
On Tue, Nov 28, 2006 at 02:08:40PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> NTFS (=m) uses hweight32(), but that function is only linked
> into the kernel image if it is used inside the kernel image,
> not in loadable modules. Let modules force HWEIGHT to be
> built into the kernel image. Otherwise build fails:
>
> Building modules, stage 2.
> MODPOST 94 modules
> WARNING: "hweight32" [fs/ntfs/ntfs.ko] undefined!
>
> Yes, I'd certainly prefer for this to be more automated rather than
> forced by each module that needs it.
Please just make it builtin-in always and remove it from lib-y.
Bonus points for killing of the lib-y braindamage entirely.
prev parent reply other threads:[~2006-11-29 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 22:08 [PATCH 1/2] lib + ntfs: let modules force HWEIGHT Randy Dunlap
2006-11-29 0:45 ` Andrew Morton
2006-11-29 0:50 ` Randy Dunlap
2006-12-02 16:56 ` Adrian Bunk
2006-12-02 17:00 ` Randy Dunlap
2006-11-29 8:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061129084009.GC12734@infradead.org \
--to=hch@infradead.org \
--cc=aia21@cantab.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.