All of lore.kernel.org
 help / color / mirror / Atom feed
From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga luci/site/luci/Extensions/StorageReport. ...
Date: 29 Nov 2006 18:26:55 -0000	[thread overview]
Message-ID: <20061129182655.10223.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	conga
Branch: 	RHEL5
Changes by:	rmccabe at sourceware.org	2006-11-29 18:26:53

Modified files:
	luci/site/luci/Extensions: StorageReport.py 
	ricci/modules/storage: LVM.cpp 

Log message:
	fix for bz #217703
	
	Related: bz217703

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/site/luci/Extensions/StorageReport.py.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.20&r2=1.20.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/modules/storage/LVM.cpp.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.7.2.1&r2=1.7.2.2

--- conga/luci/site/luci/Extensions/StorageReport.py	2006/10/16 19:49:09	1.20
+++ conga/luci/site/luci/Extensions/StorageReport.py	2006/11/29 18:26:53	1.20.2.1
@@ -1409,7 +1409,7 @@
                 # clvmd error
                 error  = True
                 url   += '?' + STONAME + '=' + storagename + '&' + PAGETYPE + '=' + STORAGE
-                msg    = 'clvmd (clustered LVM daemon) is not running on ' + storagename + '. Start it and try again.'
+                msg    = 'either clvmd (clustered LVM daemon) is not running or is not cluster-enabled on ' + storagename
             elif code == 5:
                 # not quorate
                 error  = True
--- conga/ricci/modules/storage/LVM.cpp	2006/11/01 22:06:55	1.7.2.1
+++ conga/ricci/modules/storage/LVM.cpp	2006/11/29 18:26:53	1.7.2.2
@@ -644,7 +644,8 @@
 bool 
 LVM::clustered_available()
 {
-  return get_locking_type() == "2";
+  String locking_type = get_locking_type();
+  return (locking_type == "2" || locking_type == "3");
 }
 
 bool
@@ -713,7 +714,7 @@
 void 
 LVM::check_locking()
 {
-  if (get_locking_type() == "2") {
+  if (clustered_available()) {
     if (!cluster_quorate())
       throw ClusterNotQuorateError();
     



             reply	other threads:[~2006-11-29 18:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-29 18:26 rmccabe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-03-05 20:45 [Cluster-devel] conga luci/site/luci/Extensions/StorageReport. kupcevic
2007-03-05 20:22 kupcevic
2007-03-05 20:14 kupcevic
2006-10-05 16:11 kupcevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061129182655.10223.qmail@sourceware.org \
    --to=rmccabe@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.