All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org
Subject: [2.6 patch] FW_LOADER should select HOTPLUG
Date: Sun, 3 Dec 2006 08:16:37 +0100	[thread overview]
Message-ID: <20061203071637.GA11084@stusta.de> (raw)
In-Reply-To: <20061202194022.GY11084@stusta.de>

[ fixed patch below ]

Since FW_LOADER is an option that is always select'ed by the code using 
it, it mustn't depend on HOTPLUG.

It's only relevant in the EMBEDDED=y case, but this might have resulted 
in illegal FW_LOADER=, HOTPLUG=n configurations.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old	2006-12-02 20:36:49.000000000 +0100
+++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig	2006-12-02 20:37:03.000000000 +0100
@@ -19,8 +19,8 @@
 	  If unsure say Y here.
 
 config FW_LOADER
-	tristate "Userspace firmware loading support"
-	depends on HOTPLUG
+	tristate
+	select HOTPLUG
 	---help---
 	  This option is provided for the case where no in-kernel-tree modules
 	  require userspace firmware loading support, but a module built outside
--- linux-2.6.19-rc6-mm2/drivers/pcmcia/Kconfig.old	2006-12-02 21:16:39.000000000 +0100
+++ linux-2.6.19-rc6-mm2/drivers/pcmcia/Kconfig	2006-12-02 21:16:46.000000000 +0100
@@ -6,7 +6,7 @@
 
 config PCCARD
 	tristate "PCCard (PCMCIA/CardBus) support"
-	depends on HOTPLUG
+	select HOTPLUG
 	---help---
 	  Say Y here if you want to attach PCMCIA- or PC-cards to your Linux
 	  computer.  These are credit-card size devices such as network cards,

  reply	other threads:[~2006-12-03  7:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-02 19:40 [2.6 patch] FW_LOADER should select HOTPLUG Adrian Bunk
2006-12-03  7:16 ` Adrian Bunk [this message]
2006-12-03  8:58   ` Andrew Morton
2006-12-03  8:15     ` Adrian Bunk
2006-12-03  9:24       ` Andrew Morton
2006-12-03  9:17         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061203071637.GA11084@stusta.de \
    --to=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.