From: Alan <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: always use polling IDENTIFY
Date: Sun, 3 Dec 2006 12:56:03 +0000 [thread overview]
Message-ID: <20061203125603.493ebde6@localhost.localdomain> (raw)
In-Reply-To: <20061203103032.GE11250@htj.dyndns.org>
On Sun, 3 Dec 2006 19:30:32 +0900
Tejun Heo <htejun@gmail.com> wrote:
> libata switched to IRQ-driven IDENTIFY when IRQ-driven PIO was
> introduced. This has caused a lot of problems including device
> misdetection and phantom device.
>
> ATA_FLAG_DETECT_POLLING was added recently to selectively use polling
> IDENTIFY on problemetic drivers but many controllers and devices are
> affected by this problem and trying to adding ATA_FLAG_DETECT_POLLING
> for each such case is diffcult and not very rewarding.
>
> This patch makes libata always use polling IDENTIFY. This is
> consistent with libata's original behavior and drivers/ide's behavior.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
One possibility however would be to invert the flag we have now so we can
try turning -on- IRQ polling on some devices in future and maybe figure
it out that way around ?
Alan
next prev parent reply other threads:[~2006-12-03 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 10:30 [PATCH] libata: always use polling IDENTIFY Tejun Heo
2006-12-03 11:14 ` Jeff Garzik
2006-12-03 12:34 ` [PATCH RESEND] " Tejun Heo
2006-12-03 12:58 ` Jeff Garzik
2006-12-03 12:56 ` Alan [this message]
2006-12-03 13:02 ` [PATCH] " Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061203125603.493ebde6@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.